posix: Implement pthread_equal function #60416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
reviewed
Jul 16, 2023
There was a problem hiding this comment.
@jaiiarora - Looks good, but can you please also add a second commit with tests in tests/posix/common/src/pthread.c?
Also, can you update your commit message? Technically, pthread_equal() was implemented, but your change converts it from a static inline function to a regular function.
|
Okay, I will work on it |
|
added required changes @cfriedt |
|
Please let me know if anything is missing @cfriedt. I will work on it |
cfriedt
requested changes
Jul 20, 2023
tests/posix/common/src/pthread.c
Outdated
| @@ -30,6 +30,7 @@ | |||
| K_THREAD_STACK_ARRAY_DEFINE(stack_e, N_THR_E, STACKS); | |||
| K_THREAD_STACK_ARRAY_DEFINE(stack_t, N_THR_T, STACKS); | |||
| K_THREAD_STACK_ARRAY_DEFINE(stack_1, 1, 32); | |||
| K_THREAD_STACK_DEFINE(stack_p, STACKS); | |||
Patch changes pthread_equal function from static inline to regular function type Fix for issue#59942 Signed-off-by: Jai Arora <[email protected]>
Adds test case for pthread_equal Adds test coverage for same and different thread id Signed-off-by: Jai Arora <[email protected]>
add pthread_equal to supported api list Signed-off-by: Jai Arora <[email protected]>
zephyrbot
added
area: CMSIS API Layer
cfriedt
reviewed
Jul 20, 2023
| @@ -848,4 +848,9 @@ static int posix_thread_pool_init(void) | |||
| return 0; | |||
| } | |||
|
|
|||
| int pthread_equal(pthread_t pt1, pthread_t pt2) | |||
| { | |||
| return (pt1 == pt2); | |||
There was a problem hiding this comment.
nit: no brackets needed here, but I'm not going to stop this from going in now. If there is another review that requires another spin, please fix this too.
cfriedt
added
area: Tests
cfriedt
requested review from
keith-packard,
jgl-meta and
ycsin
and removed request for
daor-oti
ycsin
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch implements pthread_equal function.
Fixes #59942