Bluetooth: controller: Fix for scanner Rx window hang #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly select CONFIG_BLUETOOTH_BROADCASTER and CONFIG_BLUETOOTH_OBSERVER in the scan_adv sample. If the Controller is included without connections support then only broadcaster support is compiled in by default, hence add broadcaster and observer role support explicitly in the prj.conf file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
The scanner was reserving a little less slot ticks which caused other roles to overlap before scan window could close. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
With the fix in commit 3c23c6f ("Bluetooth: controller: Fix assert due to stale tick count") it is required that a skipping event shall abort the previous role in order to enable the ticker_job to resume and reschedule next ticker expiry. In the scan_adv sample, with continuous scanning, an advertiser would pre-empt it, but if the advertiser skipped its event without aborting the scanner, the scanner is hung with its rx window without a timeout, and HCI command to stop the advertiser will wait forever to complete. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix missing re-initialization of ret_cb to TICKER_STATUS_BUSY before every new call to ticker interface functions' with operation's callback. One issue was undirected advertisement disable to return failure status in the scan_adv sample. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
carlescufi
approved these changes
Jun 30, 2017
jhedberg
approved these changes
Jun 30, 2017
This was referenced Sep 18, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
- There is still not support for handling these errors, but at least printing them is better than nothing Signed-off-by: James Prestwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fix in commit 3c23c6f ("Bluetooth: controller:
Fix assert due to stale tick count") it is required that a
skipping event shall abort the previous role in order to
enable the ticker_job to resume and reschedule next ticker
expiry.
In the scan_adv sample, with continuous scanning, an
advertiser would pre-empt it, but if the advertiser skipped
its event without aborting the scanner, the scanner is hung
with its rx window without a timeout, and HCI command to
stop the advertiser will wait forever to complete.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]