-
Notifications
You must be signed in to change notification settings - Fork 7.4k
posix: pthread: support for pthread_setcanceltype() #65644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cfriedt
merged 3 commits into
zephyrproject-rtos:main
from
cfriedt:pthread-setcanceltype
Nov 26, 2023
Merged
posix: pthread: support for pthread_setcanceltype() #65644
cfriedt
merged 3 commits into
zephyrproject-rtos:main
from
cfriedt:pthread-setcanceltype
Nov 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ba465c
to
86c965f
Compare
ycsin
previously approved these changes
Nov 23, 2023
86c965f
to
92ed373
Compare
pthread_setcanceltype() is required by the POSIX_THREADS_BASE Option Group as detailed in Section E.1 of IEEE-1003.1-2017. The POSIX_THREADS_BASE Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017. Signed-off-by: Christopher Friedt <[email protected]>
The function pthread_setcancelstate() has been supported for some time already in Zephyr. For some reason, it was not being checked in the "headers" testsuite. Additionally, check for pthread_setcanceltype() since it was added in a prior commit. Signed-off-by: Christopher Friedt <[email protected]>
The function pthread_setcanceltype() is supported and mandatory for conforming implementations. Mark it as supported since the preceding commit. Signed-off-by: Christopher Friedt <[email protected]>
92ed373
to
8682a91
Compare
ycsin
approved these changes
Nov 26, 2023
jhedberg
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: CMSIS API Layer
CMSIS-RTOS API Layer
area: Documentation
area: Portability
Standard compliant code, toolchain abstraction
area: POSIX
POSIX API Library
area: Tests
Issues related to a particular existing or missing test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_setcanceltype()
is required by the POSIX_THREADS_BASE Option Group as detailed in Section E.1 of IEEE-1003.1-2017.The POSIX_THREADS_BASE Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017.
Fixes #59945
Note: pthread cancellation is still basically synchronous, so cancel type has no effect.