Skip to content

board: Adding support for W5500 Eval Board. #66523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2023
Merged

board: Adding support for W5500 Eval Board. #66523

merged 2 commits into from
Dec 27, 2023

Conversation

raveious
Copy link
Contributor

The W5500_EVB_PICO is an evaluation board for the Wiznet W5500 ethernet mac/phy based on the Raspberry Pi Pico.

@github-actions GitHub Actions
Copy link

Hello @raveious, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Dec 14, 2023
@zephyrbot zephyrbot requested a review from anangl December 14, 2023 11:23
@nordicjm nordicjm dismissed their stale review December 14, 2023 11:28

addressed

@nordicjm nordicjm requested review from yonsch and soburi December 14, 2023 11:29
@raveious raveious force-pushed the w5500_evb_board branch 2 times, most recently from 0583213 to 0ed5b56 Compare December 16, 2023 03:47
@raveious raveious requested a review from nordicjm December 18, 2023 11:29
@raveious
Copy link
Contributor Author

@anangl @soburi @yonsch Would you mind reviewing this?

@raveious raveious force-pushed the w5500_evb_board branch 3 times, most recently from bfc18a4 to 997d6a8 Compare December 21, 2023 12:37
@raveious
board: Adding support for W5500 Eval Board.
8205f67 
The W5500_EVB_PICO is an evaluation board for the Wiznet W5500
ethernet mac/phy based on the Raspberry Pi Pico.

Signed-off-by: Ian Wakely <[email protected]>
@raveious
board: Fixing ADC API tests for W5500_EVB_PICO.
23d039e 
When duplicating the rpi_pico board, I had missed this test file.

Signed-off-by: Ian Wakely <[email protected]>
soburi
soburi approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raveious
Copy link
Contributor Author

Some day this'll get a second approver, today is not that day.

@yonsch yonsch mentioned this pull request Dec 24, 2023
Open
52 tasks
@fabiobaltieri fabiobaltieri merged commit 2a647c8 into zephyrproject-rtos:main Dec 27, 2023
@raveious raveious deleted the w5500_evb_board branch December 27, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soburi soburi soburi approved these changes

@nandojve nandojve nandojve left review comments

@yonsch yonsch yonsch approved these changes

@anangl anangl Awaiting requested review from anangl

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@anangl anangl

Labels
area: ADC Analog-to-Digital Converter (ADC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@raveious @soburi @nandojve @yonsch @nordicjm @fabiobaltieri @anangl @zephyrbot