posix: syslog: Fix uninitialized variable error

[jukkar]

Seen this in compiler

lib/posix/options/syslog.c: In function 'setlogmask': lib/posix/options/syslog.c:66:16: error: 'oldpri' may be used uninitialized
   66 |         return oldpri;
      |                ^~~~~~
lib/posix/options/syslog.c:59:13: note: 'oldpri' was declared here
   59 |         int oldpri;
      |             ^~~~~~
lib/posix/options/syslog.c: In function 'vsyslog':
lib/posix/options/syslog.c:83:33: error: 'mask' may be used uninitialized
   83 |         if ((BIT(level) & mask) == 0) {
      |             ~~~~~~~~~~~~~~~~~~~~^~~~
lib/posix/options/syslog.c:71:17: note: 'mask' was declared here
   71 |         uint8_t mask;
      |                 ^~~~

[cfriedt]

Yeah, this is a bit of an annoyance - a few compilers seem unable to infer that K_SPINLOCK() is entered mostly unconditionally. So the same code that does not use that helper macro does not trip warnings, even with the variable uninitialized.

[illysky]

Hi

I think I am seeing the "may be used uninitialized" warning in:

zephyr/subsys/modem/modem_pipelink.c
zephyr/subsys/modem/modem_cmux.c

FYI. Some variables such as ret and connected are treated as uninitialized when inside K_SPINLOCK.
Building on STM32H7. Only happens when compiling with Debug optimisations. Similar to this issue: #78066

Only annoyance, as I treat warnings as errors.

[jukkar]

I think I am seeing the "may be used uninitialized" warning in:

zephyr/subsys/modem/modem_pipelink.c zephyr/subsys/modem/modem_cmux.c

FYI. Some variables such as ret and connected are treated as uninitialized when inside K_SPINLOCK. Building on STM32H7. Only happens when compiling with Debug optimisations. Similar to this issue: #78066

Only annoyance, as I treat warnings as errors.

Would you be able to send a PR fixing these?