Skip to content

posix: unistd: support for confstr() #70274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Mar 15, 2024

Support getting and setting POSIX configuration variables.

confstr() is required by the POSIX_SINGLE_PROCESS Option Group as detailed in Section E.1 of IEEE-1003.1-2017.

The POSIX_SINGLE_PROCESS Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017.

With this, we have complete support for the POSIX_SINGLE_PROCESS Option Group.

Fixes #66866

@cfriedt cfriedt force-pushed the implement-confstr branch 3 times, most recently from 08a9de4 to 8071ab4 Compare March 19, 2024 09:35
@cfriedt cfriedt requested a review from ycsin March 19, 2024 09:36
@cfriedt cfriedt force-pushed the implement-confstr branch from 8071ab4 to d460a38 Compare March 19, 2024 09:40
@cfriedt cfriedt requested a review from jukkar March 19, 2024 09:41
jukkar
jukkar previously approved these changes Mar 19, 2024
@cfriedt cfriedt marked this pull request as ready for review March 19, 2024 14:44
@zephyrbot zephyrbot added the area: POSIX POSIX API Library label Mar 19, 2024
ycsin
ycsin previously approved these changes Mar 20, 2024
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cfriedt added 3 commits March 20, 2024 16:41
Support querying POSIX string configuration values (similar to
sysconf()).

confstr() is required by the POSIX_SINGLE_PROCESS Option
Group as detailed in Section E.1 of IEEE-1003.1-2017 and has
been part of the specification since POSIX-2.

The POSIX_SINGLE_PROCESS Option Group is required for PSE51,
PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory
for any POSIX conforming system as per Section A.2.1.3 of
IEEE-1003-1.2017.

With this, we have complete support for the POSIX_SINGLE_PROCESS
Option Group.

Signed-off-by: Christopher Friedt <[email protected]>
Add a test for confstr(), which is required by the
POSIX_SINGLE_PROCESS Option Group, as per IEEE
1003.1-2017.

Signed-off-by: Christopher Friedt <[email protected]>
Mark confstr() as supported in POSIX Option Groups.

Signed-off-by: Christopher Friedt <[email protected]>
@cfriedt cfriedt dismissed stale reviews from ycsin and jukkar via 05ac7ac March 20, 2024 20:41
@cfriedt cfriedt force-pushed the implement-confstr branch from a7134f3 to 05ac7ac Compare March 20, 2024 20:41
@cfriedt
Copy link
Member Author

cfriedt commented Mar 20, 2024

  • manually inserted a tab. For some reason, autoformat is not working for me 😢

@jukkar @ycsin - please re-approve, if you don't mind

Mark the POSIX_SINGLE_PROCESS Option Group as supported
in PSE51, PSE52, and PSE53 Application Environment
Profiles.

Signed-off-by: Christopher Friedt <[email protected]>
@cfriedt cfriedt force-pushed the implement-confstr branch from fcf3174 to 7e6a255 Compare March 20, 2024 22:54
@aescolar aescolar merged commit 98a121d into zephyrproject-rtos:main Mar 22, 2024
@cfriedt cfriedt deleted the implement-confstr branch April 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

posix: implement confstr()
5 participants