-
Notifications
You must be signed in to change notification settings - Fork 7.4k
posix: unistd: support for confstr() #70274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08a9de4
to
8071ab4
Compare
8071ab4
to
d460a38
Compare
jukkar
previously approved these changes
Mar 19, 2024
ycsin
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Support querying POSIX string configuration values (similar to sysconf()). confstr() is required by the POSIX_SINGLE_PROCESS Option Group as detailed in Section E.1 of IEEE-1003.1-2017 and has been part of the specification since POSIX-2. The POSIX_SINGLE_PROCESS Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017. With this, we have complete support for the POSIX_SINGLE_PROCESS Option Group. Signed-off-by: Christopher Friedt <[email protected]>
Add a test for confstr(), which is required by the POSIX_SINGLE_PROCESS Option Group, as per IEEE 1003.1-2017. Signed-off-by: Christopher Friedt <[email protected]>
Mark confstr() as supported in POSIX Option Groups. Signed-off-by: Christopher Friedt <[email protected]>
a7134f3
to
05ac7ac
Compare
Mark the POSIX_SINGLE_PROCESS Option Group as supported in PSE51, PSE52, and PSE53 Application Environment Profiles. Signed-off-by: Christopher Friedt <[email protected]>
fcf3174
to
7e6a255
Compare
ycsin
approved these changes
Mar 21, 2024
jukkar
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support getting and setting POSIX configuration variables.
confstr()
is required by thePOSIX_SINGLE_PROCESS
Option Group as detailed in Section E.1 of IEEE-1003.1-2017.The POSIX_SINGLE_PROCESS Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017.
With this, we have complete support for the
POSIX_SINGLE_PROCESS
Option Group.Fixes #66866