posix: clock: implement clock_getres() #70525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
reviewed
Mar 21, 2024
lib/posix/options/clock.c
Outdated
| @@ -97,6 +97,28 @@ int clock_gettime(clockid_t clock_id, struct timespec *ts) | |||
| return 0; | |||
| } | |||
|
|
|||
| int clock_getres(clock_t clock_id, struct timespec *res) | |||
There was a problem hiding this comment.
Suggested change
| int clock_getres(clock_t clock_id, struct timespec *res) | |
| int clock_getres(clockid_t clock_id, struct timespec *res) |
clock_getres() is required by the POSIX_TIMERS Option Group as detailed in Section E.1 of IEEE-1003.1-2017. The POSIX_TIMERS Option Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017. With this, we have complete support for the POSIX_TIMERS Option Group. Signed-off-by: Christopher Friedt <[email protected]>
Add a test for clock_getres(). Signed-off-by: Christopher Friedt <[email protected]>
Mark clock_getres() as supported in the POSIX_TIMERS Option Group. Signed-off-by: Christopher Friedt <[email protected]>
ycsin
approved these changes
Mar 21, 2024
jukkar
approved these changes
Mar 22, 2024
|
It looks like the 2d review period is up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of
clock_getres(). Clock resolution is currently limited to the inverse ofCLOCK_TICKS_PER_SECONDas there is no direct relationship between hardware clocks and the POSIX variety in Zephyr.The
clock_getres()function is required by thePOSIX_TIMERSOption Group as detailed in Section E.1 of IEEE-1003.1-2017.The
POSIX_TIMERSOption Group is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017.With this, we have complete support for the
POSIX_TIMERSOption Group.Fixes #59955