Update tcpserversink sample #73665
Merged
Update tcpserversink sample #73665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run clang-format before making any changes Signed-off-by: Phi Bang Nguyen <[email protected]>
Add a new line so that logs are easier to be read. Signed-off-by: Phi Bang Nguyen <[email protected]>
The default resolution of mt9m114 camera is now changed to 480x272. Update the sample documentation to reflect this change. Signed-off-by: Phi Bang Nguyen <[email protected]>
Update the sample to use a camera shield with a camera chosen node. This is not only because the camera nodes in the mimxrt1064 device tree has been now moved to a separate mt9m114 shield but also to make the sample more generic. Signed-off-by: Phi Bang Nguyen <[email protected]>
Add support for video software generator in case of a real video capture device is missing. Signed-off-by: Phi Bang Nguyen <[email protected]>
ngphibang
force-pushed
the
update_tcpserversink_sample
branch
from
dbdd9b8 to
b74d17d
Compare
|
@loicpoulain @danieldegrasse Would you help to review this ? |
kartben
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the sample should not rely on the fact that the NXP CSI node is always enabled and if this is required, sample.yaml should have
filter: dt_compat_enabled("nxp,imx-csi").As #72435 is now merged and as pointed out by #73604, update this sample to reflect the new shield.
Some minor improvements are also made such as adding support for video software generator.