boards: shields: add suport for st_b_cams_omv_mb1683 #76143

CharlesDias · 2024-07-21T21:05:04Z

Add support for ST B-CAMS-OMV MB1683 shield.

Required PR:

Testing on STM32H7B3I-DK

west build -p -b stm32h7b3i_dk --shield st_b_cams_omv_mb1683 samples/drivers/video/capture_to_lvgl/

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

CharlesDias · 2024-10-12T18:19:33Z

Rebase.

CharlesDias · 2024-10-12T18:22:44Z

Updated endpoint configuration according to #74415.

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay

samples/drivers/video/capture_to_lvgl/boards/stm32h7b3i_dk.conf

kartben · 2024-11-26T15:42:58Z

@CharlesDias will you be able to revisit this PR?

CharlesDias · 2025-02-01T11:12:16Z

Rebase

josuah

Some optional proposals to avoid easy mistakes.
Besides this, I do not see anything else missing, and LGTM!

josuah · 2025-02-04T13:32:46Z

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

+``_st_b_cams_omv_mb1683`` and adding the necessary device tree properties.
+
+Set ``--shield "_st_b_cams_omv_mb1683"`` when you invoke ``west build``. For example:


_st_b_cams_omv_mb1683 -> st_b_cams_omv_mb1683 ?
Is it a copy-paste typo from the title or is the --shield flag works with the leading underscore?
Thanks!

My bad! Thanks for catching it! I'll fix!

josuah · 2025-02-04T13:45:37Z

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

+     :alt: B-CAMS-OMV-MB1683
+
+     B-CAMS-OMV MB1683 Image (Credit: STMicroelectronics.)
+


I am tempted to add a short sentence reminding what this is documenting, as it is easily mistaken by the connector that is in the devicetree (different pinout). Like this or any other wording:

The camera signals go into the shield from one of the supported input connectors (CN1, CN2, CN4), and out of the shield towards Zephyr through the output 30-pin ZIF connector CN5.

In addition, how about something like:

Suggested change

refer to the User manual for CN1 and CN2 pinout

josuah · 2025-02-04T13:45:59Z

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

+
+     B-CAMS-OMV MB1683 Image (Credit: STMicroelectronics.)
+
+Waveshare camera board connector CN4


Suggested change

Waveshare camera board connector CN4

Waveshare camera board connector CN4 (camera input)

For reference:

https://www.st.com/resource/en/user_manual/um2779-camera-module-bundle-for-stm32-boards-stmicroelectronics.pdf

josuah · 2025-02-04T13:48:27Z

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

+| 17         | PWR_EN / LED1   | 18         | RESET#       |
+------------+-----------------+------------+--------------+
+
+ZIF connector CN5


Suggested change

ZIF connector CN5

ZIF connector CN5 (camera output)

For reference:

josuah · 2025-02-04T14:06:51Z

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

+------------+--------------+------------+--------------+
+| Pin number | Description  | Pin number | Description  |
+============+==============+============+==============+
+| 1          | 3V3          | 16         | DCMI_PIXCK   |
+------------+--------------+------------+--------------+
+| 2          | GND          | 17         | GND          |
+------------+--------------+------------+--------------+
+| 3          | I2C_SCL      | 18         | SPI_MISO     |
+------------+--------------+------------+--------------+
+| 4          | I2C_SDA      | 19         | SPI_CS       |
+------------+--------------+------------+--------------+
+| 5          | RESET#       | 20         | DCMI_D7      |
+------------+--------------+------------+--------------+
+| 6          | PWR_EN / LED1| 21         | DCMI_D6      |
+------------+--------------+------------+--------------+
+| 7          | SHUTTER      | 22         | DCMI_D5      |
+------------+--------------+------------+--------------+
+| 8          | GND          | 23         | DCMI_D4      |
+------------+--------------+------------+--------------+
+| 9          | PULLDOWN / LED2 | 24      | DCMI_D3      |
+------------+--------------+------------+--------------+
+| 10         | Camera_CLK   | 25         | DCMI_D2      |
+------------+--------------+------------+--------------+
+| 11         | 3V3          | 26         | DCMI_D1      |
+------------+--------------+------------+--------------+
+| 12         | DCMI_VSYNC   | 27         | DCMI_D0      |
+------------+--------------+------------+--------------+
+| 13         | 5V (RSU)     | 28         | SPI_MOSI     |
+------------+--------------+------------+--------------+
+| 14         | DCMI_HSYNC   | 29         | SPI_CLK      |
+------------+--------------+------------+--------------+
+| 15         | GND          | 30         | GND          |
+------------+--------------+------------+--------------+


ST used a 2-columns table for aesthetical reasons, but we could consider preserving the layout of the 30-pin connector for clarity:

Suggested change

+------------+--------------+------------+--------------+

| Pin number | Description | Pin number | Description |

+============+==============+============+==============+

| 1 | 3V3 | 16 | DCMI_PIXCK |

+------------+--------------+------------+--------------+

| 2 | GND | 17 | GND |

+------------+--------------+------------+--------------+

| 3 | I2C_SCL | 18 | SPI_MISO |

+------------+--------------+------------+--------------+

| 4 | I2C_SDA | 19 | SPI_CS |

+------------+--------------+------------+--------------+

| 5 | RESET# | 20 | DCMI_D7 |

+------------+--------------+------------+--------------+

| 6 | PWR_EN / LED1| 21 | DCMI_D6 |

+------------+--------------+------------+--------------+

| 7 | SHUTTER | 22 | DCMI_D5 |

+------------+--------------+------------+--------------+

| 8 | GND | 23 | DCMI_D4 |

+------------+--------------+------------+--------------+

| 9 | PULLDOWN / LED2 | 24 | DCMI_D3 |

+------------+--------------+------------+--------------+

| 10 | Camera_CLK | 25 | DCMI_D2 |

+------------+--------------+------------+--------------+

| 11 | 3V3 | 26 | DCMI_D1 |

+------------+--------------+------------+--------------+

| 12 | DCMI_VSYNC | 27 | DCMI_D0 |

+------------+--------------+------------+--------------+

| 13 | 5V (RSU) | 28 | SPI_MOSI |

+------------+--------------+------------+--------------+

| 14 | DCMI_HSYNC | 29 | SPI_CLK |

+------------+--------------+------------+--------------+

| 15 | GND | 30 | GND |

+------------+--------------+------------+--------------+

+------------+-----------------+

| Pin number | Description |

+============+=================+

| 1 | 3V3 |

+------------+-----------------+

| 2 | GND |

+------------+-----------------+

| 3 | I2C_SCL |

+------------+-----------------+

| 4 | I2C_SDA |

+------------+-----------------+

| 5 | RESET# |

+------------+-----------------+

| 6 | PWR_EN / LED1 |

+------------+-----------------+

| 7 | SHUTTER |

+------------+-----------------+

| 8 | GND |

+------------+-----------------+

| 9 | PULLDOWN / LED2 |

+------------+-----------------+

| 10 | Camera_CLK |

+------------+-----------------+

| 11 | 3V3 |

+------------+-----------------+

| 12 | DCMI_VSYNC |

+------------+-----------------+

| 13 | 5V (RSU) |

+------------+-----------------+

| 14 | DCMI_HSYNC |

+------------+-----------------+

| 15 | GND |

+------------+-----------------+

| 16 | DCMI_PIXCK |

+------------+-----------------+

| 17 | GND |

+------------+-----------------+

| 18 | SPI_MISO |

+------------+-----------------+

| 19 | SPI_CS |

+------------+-----------------+

| 20 | DCMI_D7 |

+------------+-----------------+

| 21 | DCMI_D6 |

+------------+-----------------+

| 22 | DCMI_D5 |

+------------+-----------------+

| 23 | DCMI_D4 |

+------------+-----------------+

| 24 | DCMI_D3 |

+------------+-----------------+

| 25 | DCMI_D2 |

+------------+-----------------+

| 26 | DCMI_D1 |

+------------+-----------------+

| 27 | DCMI_D0 |

+------------+-----------------+

| 28 | SPI_MOSI |

+------------+-----------------+

| 29 | SPI_CLK |

+------------+-----------------+

| 30 | GND |

+------------+-----------------+

josuah · 2025-02-04T14:22:47Z

dts/bindings/gpio/st,dcmi-camera-fpu-330zh.yaml

+    (1)   3V3                 (2)   GND
+    (3)   I2C_SCL             (4)   I2C_SDA
+    (5)   RESET#              (6)   PWR_EN / LED1
+    (7)   SHUTTER             (8)   GND
+    (9)   PULLDOWN / LED2     (10)  Camera_CLK
+    (11)  3V3                 (12)  DCMI_VSYNC
+    (13)  5V (RSU)            (14)  DCMI_HSYNC
+    (15)  GND                 (16)  DCMI_PIXCK
+    (17)  GND                 (18)  SPI_MISO
+    (19)  SPI_CS              (20)  DCMI_D7
+    (21)  DCMI_D6             (22)  DCMI_D5
+    (23)  DCMI_D4             (24)  DCMI_D3
+    (25)  DCMI_D2             (26)  DCMI_D1
+    (27)  DCMI_D0             (28)  SPI_MOSI
+    (29)  SPI_CLK             (30)  GND


At your disposition, a more verbose but less ambiguous alternative:

Suggested change

(1) 3V3 (2) GND

(3) I2C_SCL (4) I2C_SDA

(5) RESET# (6) PWR_EN / LED1

(7) SHUTTER (8) GND

(9) PULLDOWN / LED2 (10) Camera_CLK

(11) 3V3 (12) DCMI_VSYNC

(13) 5V (RSU) (14) DCMI_HSYNC

(15) GND (16) DCMI_PIXCK

(17) GND (18) SPI_MISO

(19) SPI_CS (20) DCMI_D7

(21) DCMI_D6 (22) DCMI_D5

(23) DCMI_D4 (24) DCMI_D3

(25) DCMI_D2 (26) DCMI_D1

(27) DCMI_D0 (28) SPI_MOSI

(29) SPI_CLK (30) GND

(1) 3V3

(2) GND

(3) I2C_SCL

(4) I2C_SDA

(5) RESET#

(6) PWR_EN / LED1

(7) SHUTTER

(8) GND

(9) PULLDOWN / LED2

(10) Camera_CLK

(11) 3V3

(12) DCMI_VSYNC

(13) 5V (RSU)

(14) DCMI_HSYNC

(15) GND

(16) DCMI_PIXCK

(17) GND

(18) SPI_MISO

(19) SPI_CS

(20) DCMI_D7

(21) DCMI_D6

(22) DCMI_D5

(23) DCMI_D4

(24) DCMI_D3

(25) DCMI_D2

(26) DCMI_D1

(27) DCMI_D0

(28) SPI_MOSI

(29) SPI_CLK

(30) GND

If preserving the original "2-column" layout, it could help to transpose the table so that it looks like the one in the doc and PDF.

boards/shields/st_b_cams_omv_mb1683/Kconfig.defconfig

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay

boards/shields/st_b_cams_omv_mb1683/Kconfig.defconfig

samples/drivers/video/capture_to_lvgl/boards/stm32h7b3i_dk.overlay

samples/drivers/video/capture_to_lvgl/boards/stm32h7b3i_dk.conf

boards/shields/st_b_cams_omv_mb1683/Kconfig.shield

dts/bindings/gpio/st,dcmi-camera-fpu-330zh.yaml

CharlesDias · 2025-02-04T20:49:31Z

Implemented previous suggestions, except this one #76143 (comment).

@erwango and @ngphibang, do you mean?

config VIDEO_STM32_DCMI
	default y
	depends on DT_HAS_ST_STM32_DCMI_ENABLED

CharlesDias · 2025-02-05T07:47:27Z

Implemented suggestion #76143 (comment).

config VIDEO_STM32_DCMI
	default y
	depends on DT_HAS_ST_STM32_DCMI_ENABLED

CharlesDias · 2025-02-05T08:35:33Z

Delete boards/shields/st_b_cams_omv_mb1683/Kconfig.defconfig once VIDEO_STM32_DCMI config is already defined in the driver's Kconfig.

ngphibang

In general, I think we should clarify if the shield is specific only to ST boards or generic enough for any 30-pin dvp camera interface, then the shield name, readme, node labels will be made according to it. I learned some lessons from @kartben 's comments in these shield PRs :-)

Add a shield for DVP FPC 24-pins mt9m114 camera modules #72435 (generic case)
boards: shields: Add shield for NXP's ov5640 camera modules #72434 (specific case)

boards/st/stm32h7b3i_dk/stm32h7b3i_dk.dts

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay

boards/shields/st_b_cams_omv_mb1683/doc/index.rst

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay

Add support for ST B-CAMS-OMV MB1683 shield. Signed-off-by: Charles Dias <[email protected]>

erwango · 2025-02-06T07:42:26Z

@ngphibang For your next round of review, would you mind closing the discussion on comments that have been addressed ? This will be helpful for other reviewers. Thanks!

ngphibang

LGTM, but other reviewers may have some findings

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay

ngphibang · 2025-02-06T08:21:23Z

@erwango Yes, done. Sorry !

erwango

LGTM.

@josuah PTAL

CharlesDias marked this pull request as draft July 21, 2024 21:05

zephyrbot added the area: Shields Shields (add-on boards) label Jul 21, 2024

zephyrbot requested review from avisconti, erwango, jfischer-no and kartben July 21, 2024 21:05

zephyrbot assigned kartben Jul 21, 2024

This was referenced Jul 21, 2024

Improve the ov5640 video driver to provide parallel interface (DVP) support. #74353

Open

Add parallel interface (DVP) support for ov5640 driver #76124

Merged

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch 2 times, most recently from 4377923 to 74f10a5 Compare July 22, 2024 20:44

josuah added area: Video Video subsystem area: camera labels Jul 22, 2024

erwango reviewed Jul 30, 2024

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/doc/index.rst Outdated Show resolved Hide resolved

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from 74f10a5 to f9b29d6 Compare August 4, 2024 10:49

CharlesDias changed the title ~~boards: shields: add suport for st_b_cams_omv_mb1683~~ [DNM] boards: shields: add suport for st_b_cams_omv_mb1683 Aug 5, 2024

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from f9b29d6 to de6b1c4 Compare September 14, 2024 19:59

CharlesDias marked this pull request as ready for review September 14, 2024 21:49

zephyrbot added the area: Samples Samples label Sep 14, 2024

zephyrbot requested review from josuah, loicpoulain and nashif September 14, 2024 21:50

CharlesDias changed the title ~~[DNM] boards: shields: add suport for st_b_cams_omv_mb1683~~ boards: shields: add suport for st_b_cams_omv_mb1683 Sep 14, 2024

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from de6b1c4 to 0f11eb8 Compare October 12, 2024 18:19

zephyrbot requested a review from ngphibang October 12, 2024 18:20

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from 0f11eb8 to 32b6c74 Compare October 12, 2024 18:21

ngphibang reviewed Oct 14, 2024

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay Show resolved Hide resolved

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay Show resolved Hide resolved

samples/drivers/video/capture_to_lvgl/boards/stm32h7b3i_dk.conf Outdated Show resolved Hide resolved

zephyrbot requested review from GeorgeCGV, marwaiehm-st and mathieuchopstm December 21, 2024 12:30

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from 6f2b0c4 to f87584a Compare February 1, 2025 11:04

josuah reviewed Feb 4, 2025

View reviewed changes

erwango reviewed Feb 4, 2025

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/Kconfig.defconfig Outdated Show resolved Hide resolved

ngphibang reviewed Feb 4, 2025

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay Outdated Show resolved Hide resolved

ngphibang reviewed Feb 4, 2025

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/st_b_cams_omv_mb1683.overlay Outdated Show resolved Hide resolved

ngphibang reviewed Feb 4, 2025

View reviewed changes

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from f87584a to f5bb46e Compare February 4, 2025 20:47

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from f5bb46e to 049687f Compare February 5, 2025 07:40

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from 049687f to f6140f4 Compare February 5, 2025 08:32

ngphibang reviewed Feb 5, 2025

View reviewed changes

boards: shields: add suport for st_b_cams_omv_mb1683

da7c49b

Add support for ST B-CAMS-OMV MB1683 shield. Signed-off-by: Charles Dias <[email protected]>

CharlesDias force-pushed the st_b_cams_omv_mb1683 branch from f6140f4 to da7c49b Compare February 5, 2025 19:04

JarmouniA added this to the v4.1.0 milestone Feb 5, 2025

JarmouniA requested a review from kartben February 5, 2025 19:50

JarmouniA requested review from josuah and loicpoulain February 6, 2025 08:15

ngphibang approved these changes Feb 6, 2025

View reviewed changes

boards/shields/st_b_cams_omv_mb1683/boards/stm32h7b3i_dk.overlay Show resolved Hide resolved

erwango approved these changes Feb 6, 2025

View reviewed changes

kartben approved these changes Feb 6, 2025

View reviewed changes

JarmouniA approved these changes Feb 6, 2025

View reviewed changes

kartben merged commit 435b6f6 into zephyrproject-rtos:main Feb 6, 2025
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: shields: add suport for st_b_cams_omv_mb1683 #76143

boards: shields: add suport for st_b_cams_omv_mb1683 #76143

CharlesDias commented Jul 21, 2024 •

edited

Loading

CharlesDias commented Oct 12, 2024

CharlesDias commented Oct 12, 2024

kartben commented Nov 26, 2024

CharlesDias commented Feb 1, 2025

josuah left a comment

josuah Feb 4, 2025

CharlesDias Feb 4, 2025 •

edited

Loading

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

josuah Feb 4, 2025

CharlesDias commented Feb 4, 2025 •

edited

Loading

CharlesDias commented Feb 5, 2025 •

edited

Loading

CharlesDias commented Feb 5, 2025

ngphibang left a comment

erwango commented Feb 6, 2025

ngphibang left a comment

ngphibang commented Feb 6, 2025

erwango left a comment

		``_st_b_cams_omv_mb1683`` and adding the necessary device tree properties.

		Set ``--shield "_st_b_cams_omv_mb1683"`` when you invoke ``west build``. For example:

		:alt: B-CAMS-OMV-MB1683

		B-CAMS-OMV MB1683 Image (Credit: STMicroelectronics.)


		B-CAMS-OMV MB1683 Image (Credit: STMicroelectronics.)

		Waveshare camera board connector CN4

	Waveshare camera board connector CN4
	Waveshare camera board connector CN4 (camera input)

boards: shields: add suport for st_b_cams_omv_mb1683 #76143

boards: shields: add suport for st_b_cams_omv_mb1683 #76143

Conversation

CharlesDias commented Jul 21, 2024 • edited Loading

CharlesDias commented Oct 12, 2024

CharlesDias commented Oct 12, 2024

kartben commented Nov 26, 2024

CharlesDias commented Feb 1, 2025

josuah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CharlesDias Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CharlesDias commented Feb 4, 2025 • edited Loading

CharlesDias commented Feb 5, 2025 • edited Loading

CharlesDias commented Feb 5, 2025

ngphibang left a comment

Choose a reason for hiding this comment

erwango commented Feb 6, 2025

ngphibang left a comment

Choose a reason for hiding this comment

ngphibang commented Feb 6, 2025

erwango left a comment

Choose a reason for hiding this comment

CharlesDias commented Jul 21, 2024 •

edited

Loading

CharlesDias Feb 4, 2025 •

edited

Loading

CharlesDias commented Feb 4, 2025 •

edited

Loading

CharlesDias commented Feb 5, 2025 •

edited

Loading