Skip to content

drivers: video: introduce CONFIG_VIDEO_LOG_LEVEL #76393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josuah
Copy link
Collaborator

@josuah josuah commented Jul 28, 2024

Zephyr drivers have typically one log level defined per class. The video drivers were making exception. This adds the missing log level for video drivers.

Since all headers had to be modified, this also:

@josuah josuah self-assigned this Jul 28, 2024
@josuah josuah added priority: low Low impact/importance bug area: Drivers area: Logging area: Video Video subsystem labels Jul 28, 2024
@josuah josuah force-pushed the pr-drivers-video-log-level branch from 6108d49 to 00e067a Compare July 28, 2024 15:33
@josuah
Copy link
Collaborator Author

josuah commented Jul 28, 2024

It is not expected to have breaking changes, except for the STM32 DCMI driver, which looses its CONFIG_STM32_DCMI_LOG_LEVEL.

However, it was introduced recently (bdd4e61) and not by ST, so hopefully ST will not have internal documentation to update yet.

@josuah josuah marked this pull request as ready for review July 28, 2024 15:37
@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers platform: STM32 ST Micro STM32 labels Jul 28, 2024
@josuah josuah force-pushed the pr-drivers-video-log-level branch from 00e067a to 14570af Compare July 29, 2024 13:45
@kartben
Copy link
Collaborator

kartben commented Sep 4, 2024

@josuah please rebase to retrigger CI

Zephyr drivers have typically one log level defined per class. The video
drivers were making exception. This adds the missing log level for video
drivers.

Since all headers had to be modified, this also:

- Update the log initialization to the new syntax from 5e34681

- Sort the #include list to something like zephyrproject-rtos#41543

Signed-off-by: Josuah Demangeon <[email protected]>
@josuah josuah force-pushed the pr-drivers-video-log-level branch from 14570af to 49c3723 Compare September 5, 2024 10:27
@mmahadevan108 mmahadevan108 merged commit 0ac91da into zephyrproject-rtos:main Sep 5, 2024
23 checks passed
@josuah josuah deleted the pr-drivers-video-log-level branch September 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers area: Logging area: Video Video subsystem platform: NXP Drivers NXP Semiconductors, drivers platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants