scripts: ci: guideline_check: mitigate excessive false positives #77104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
skip-coccicheck-for-libc-and-posix
branch
2 times, most recently
from
b4dfbdb to
4171425
Compare
In order to reduce excessive false positives for Coding Guidelines checks in CI, maintain a list of paths that are marked "safe" for reserved names to be implemented or declared. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
skip-coccicheck-for-libc-and-posix
branch
from
4171425 to
9a4bec3
Compare
|
cant tell why the CI failed, triggered them to rerun |
GH was down for a fair while yesterday. |
nashif
approved these changes
Aug 15, 2024
zephyrbot
added
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
simhein and
stephanosio
simhein
approved these changes
Aug 15, 2024
ycsin
approved these changes
Aug 15, 2024
fabiobaltieri
approved these changes
Aug 15, 2024
keith-zephyr
approved these changes
Aug 15, 2024
|
I'm going to go ahead and merge this to unblock other PRs, since it's green and looks like it has all of the required approvals. Normally, I try to avoid merging my own PRs though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a list of exclusion regexes for coccinelle.
Fixes #77103