Skip to content

tester: bas: Add support for testing Battery Service #77745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tester: bas: Add support for testing Battery Service #77745

wants to merge 1 commit into from
+553 −1

Conversation

MicImbriani
Copy link

@MicImbriani MicImbriani commented Aug 29, 2024 •
edited
Loading

Currently only support mandatory Battery Level and optional Level Status Characteristic.

Signed-off-by: Michele Imbriani [email protected]

@zephyrbot zephyrbot added area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests labels Aug 29, 2024
@github-actions GitHub Actions
Copy link

Hello @MicImbriani, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@MicImbriani MicImbriani force-pushed the bas_sup branch 4 times, most recently from 17fd78e to 4a1f72b Compare August 30, 2024 09:51
Thalley
Thalley requested changes Sep 2, 2024
View reviewed changes
@MicImbriani MicImbriani force-pushed the bas_sup branch 4 times, most recently from fc0ff0d to 79b909b Compare September 4, 2024 13:49
@MicImbriani MicImbriani force-pushed the bas_sup branch 3 times, most recently from bbe618e to b9bb5d7 Compare December 2, 2024 08:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 1, 2025
@Thalley Thalley removed the Stale label Feb 3, 2025
@MicImbriani MicImbriani force-pushed the bas_sup branch 2 times, most recently from a4fab00 to eef8d0b Compare February 3, 2025 14:14
Thalley
Thalley previously approved these changes Feb 3, 2025
View reviewed changes
@MicImbriani
Copy link
Author

@sjanc please re-review.

niym-ot
niym-ot previously approved these changes Feb 11, 2025
View reviewed changes
sjanc
sjanc reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, few minor nitpicks

@MicImbriani MicImbriani dismissed stale reviews from niym-ot and Thalley via 0ca02d7 February 12, 2025 12:57
@MicImbriani MicImbriani requested a review from sjanc February 12, 2025 13:20
@MicImbriani
tester: bas: Add support for testing Battery Service
7680b18 
Currently only support mandatory Battery Level and optional Level Status
Characteristic.

Signed-off-by: Michele Imbriani <[email protected]>
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 15, 2025
@Thalley Thalley removed the Stale label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thalley Thalley Thalley approved these changes

@jhedberg jhedberg Awaiting requested review from jhedberg

@larsgk larsgk Awaiting requested review from larsgk

@manuargue manuargue Awaiting requested review from manuargue

@ydamigos ydamigos Awaiting requested review from ydamigos

@avisconti avisconti Awaiting requested review from avisconti

@ceolin ceolin Awaiting requested review from ceolin

@nashif nashif Awaiting requested review from nashif

@cfriedt cfriedt Awaiting requested review from cfriedt

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@sjg20 sjg20 Awaiting requested review from sjg20

@teburd teburd Awaiting requested review from teburd

@sjanc sjanc Awaiting requested review from sjanc

@niym-ot niym-ot Awaiting requested review from niym-ot

Requested changes must be addressed to merge this pull request.

Assignees

@sjanc sjanc

Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MicImbriani @zephyrbot @Thalley @sjanc @niym-ot