boards: arduino_nicla_vision: add initial support for the camera system #78422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uLipe
changed the title
josuah
reviewed
Sep 13, 2024
initial support on device tree Signed-off-by: Felipe Neves <[email protected]>
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
ae99b65 to
a04a9d5
Compare
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
a04a9d5 to
8868b11
Compare
uLipe
changed the title
|
Just ran clang-format again on the GC2145 driver |
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
3 times, most recently
from
026aff9 to
4688740
Compare
kartben
previously requested changes
Sep 18, 2024
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
4688740 to
143a9e1
Compare
kartben
dismissed
their stale review
"only" unblocking for now as I might not have time to review more thoroughly in the immediate future. Thanks for quickly addressing my comments!
josuah
previously approved these changes
Sep 18, 2024
samples/drivers/video/capture/boards/arduino_nicla_vision_stm32h747xx_m7.conf
Show resolved
Hide resolved
samples/drivers/video/capture/boards/arduino_nicla_vision_stm32h747xx_m7.overlay
Outdated
Show resolved
Hide resolved
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
143a9e1 to
c2b78ad
Compare
josuah
previously approved these changes
Sep 19, 2024
pillo79
reviewed
Sep 19, 2024
There was a problem hiding this comment.
This looks great! Not an expert here so these are more questions than actual comments, please bear with me.
Also, FYI - even when replying on your own PR, you can "start a review" on GitHub by going to the Files tab. This greatly reduces the number of email messages to other reviewers 🙂
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
c2b78ad to
5c52be6
Compare
josuah
reviewed
Sep 19, 2024
josuah
previously approved these changes
Sep 19, 2024
pillo79
reviewed
Sep 19, 2024
Add VGA and QVGA resolution support to enable usage of gc2145 sensor by smaller ram capable devices. Signed-off-by: Felipe Neves <[email protected]>
As supported board to the video capture sample. Signed-off-by: Felipe Neves <[email protected]>
uLipe
force-pushed
the
feature/arduino_nicla_vision_camera
branch
from
5c52be6 to
0b5da7a
Compare
|
One more round folks, we are almost there :) |
josuah
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of the camera subsystem for the Arduino Nicla Vision, in order to make it to work this PR covered: