Skip to content

spi: spi_ll_stm32: fix slave frame shifting #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

superna9999
Copy link
Collaborator

In the current form of the code, the slave frame shifting leaves the TX
full and will shift out some unwanted bytes out on the next transaction.

This PR is a subset of #5200 without the test.

This fix is needed for #7687

In the current form of the code, the slave frame shifting leaves the TX
full and will shift out some unwanted bytes out on the next transaction.

Signed-off-by: Neil Armstrong <[email protected]>
@superna9999 superna9999 requested a review from tbursztyka May 24, 2018 10:15
@superna9999 superna9999 added area: SPI SPI bus platform: STM32 ST Micro STM32 bug The issue is a bug, or the PR is fixing a bug labels May 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #7853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7853   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         483      483           
  Lines       53968    53968           
  Branches    10501    10501           
=======================================
  Hits        29694    29694           
  Misses      19986    19986           
  Partials     4288     4288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9174c6...fc1c804. Read the comment docs.

@galak galak requested a review from erwango May 24, 2018 13:19
@avisconti
Copy link
Collaborator

avisconti commented May 28, 2018

I'm currently using this commit and it seems to work fine.

@nashif nashif merged commit 7fb245f into zephyrproject-rtos:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: SPI SPI bus bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants