STM32 UART DRIVER : add support for buffer circular mode #80921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
dcpleung,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
kartben,
marwaiehm-st,
mathieuchopstm,
nashif and
teburd
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
from
5528a3b to
69501cb
Compare
|
I have not analyzed the PR in detail, but saw some fragments of code that could possibly touching a solution to discussion in: |
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
from
69501cb to
947391d
Compare
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
2 times, most recently
from
28188de to
0c00ab2
Compare
JarmouniA
reviewed
Nov 12, 2024
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
2 times, most recently
from
b2f4f3c to
3e3832b
Compare
JarmouniA
reviewed
Nov 12, 2024
JarmouniA
reviewed
Nov 12, 2024
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
2 times, most recently
from
57ac9d1 to
1ed34bc
Compare
erwango
reviewed
Nov 21, 2024
erwango
reviewed
Nov 21, 2024
samples/boards/st/uart/circular_dma/boards/nucleo_c031c6.overlay
Outdated
Show resolved
Hide resolved
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
from
1ed34bc to
98d3974
Compare
erwango
requested changes
Nov 22, 2024
samples/boards/st/uart/circular_dma/boards/nucleo_c031c6.overlay
Outdated
Show resolved
Hide resolved
samples/boards/st/uart/circular_dma/boards/nucleo_f091rc.overlay
Outdated
Show resolved
Hide resolved
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
4 times, most recently
from
f10dc6c to
74b3e52
Compare
JarmouniA
reviewed
Dec 6, 2024
samples/boards/st/uart/circular_dma/boards/nucleo_c031c6.overlay
Outdated
Show resolved
Hide resolved
samples/boards/st/uart/circular_dma/boards/nucleo_f091rc.overlay
Outdated
Show resolved
Hide resolved
samples/boards/st/uart/circular_dma/boards/nucleo_g071rb.overlay
Outdated
Show resolved
Hide resolved
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
5 times, most recently
from
7887fbe to
4d136e6
Compare
erwango
requested changes
Jan 8, 2025
This macro will help us to enable the 5th bit CIRC on the DMA_CCRx register for all stm32 series having this configuration. Thus the DMA will be able to handle the circular buffers. Signed-off-by: Fabrice DJIATSA <[email protected]> co-authored-by: Cyril Fougeray <[email protected]>
the following implementations are added: - set cyclic variable to handle circular/normal mode : enable dest/source_reload_en variable to set CIRC bit to 1 for RX or TX. - DMA_STATUS_COMPLETE(0), DMA_STATUS_BLOCK(1) macros to handle half and full irq - add ASYNC_UART_STATUS_TIMEOUT(3) macro to work with default mode - add status input in uart_stm32_dma_rx_flush function to handle async events depending on the mode we are in. Signed-off-by: Fabrice DJIATSA <[email protected]> co-authored-by: Cyril Fougeray <[email protected]>
This code example will demonstrate how to use uart circular mode on STM32 boards. Signed-off-by: Fabrice DJIATSA <[email protected]>
djiatsaf-st
force-pushed
the
uart_circular_mode
branch
from
4d136e6 to
9936356
Compare
erwango
approved these changes
Jan 9, 2025
gautierg-st
approved these changes
Jan 10, 2025
|
will try that hopefully today! EDIT: works first try by using same DTS as in overlay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the implementation of the circular mode in the uart communication on the stm32 driver.
It is inspired by this commit 7275280#diff-54bdff4ff3a16e194201b66e24cada279fdfdd40dfd66b1df3df3a99d0f65cd0R1007 made by @fouge
The cyclic mode will be configured from the devicetree and will also have the management of the dma buffer with the integration of the half full and full irq .
This implementation is compatible with all STM32 series that have the CIRC bit at the 5th position of the DMA_CCRx register.
A sample driver has been made available and tested on the C0, F0 and G0 series with communication speeds reaching up to 500kbps.
Fixes #79831