tests/kernel/preempt: Add yield and sleep cases #8133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduler choice is subtle across yield and k_sleep(), add calls to those to the state table and validate that we're making the right decisions. Signed-off-by: Andy Ross <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8133 +/- ##
==========================================
- Coverage 64.54% 64.54% -0.01%
==========================================
Files 420 420
Lines 40142 40142
Branches 6765 6765
==========================================
- Hits 25911 25910 -1
Misses 11110 11110
- Partials 3121 3122 +1
Continue to review full report at Codecov.
|
mike-scott
suggested changes
Jun 4, 2018
| last_thread = NULL; | ||
| k_sem_give(&worker_sems[id]); | ||
|
|
||
| while (do_sleep | ||
| && !(worker_threads[id].base.thread_state & _THREAD_PENDING)) { |
There was a problem hiding this comment.
Won't this test immediately break when you submit the k_sleep re-write for v1.13?
There was a problem hiding this comment.
Likely, yes. :) But I'm whiteboxing the thread states here anyway and this is the easiest way to make sure the thread is blocked on the semaphore again before going to the next test case.
There was a problem hiding this comment.
Sounds good. Removing my -1.
mike-scott
approved these changes
Jun 4, 2018
andrewboie
approved these changes
Jun 4, 2018
nashif
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Added test cases to try to catch the k_sleep() bug that Michael Scott and I were sure he had found in #8128. Alas, this test PASSES, and I've now convinced myself that the bug wasn't real (though the symptoms are and there may be a similar issue elsewhere, just now with k_sleep()). But they're useful regression cases and untested in current code, so worth commiting regardless]
Scheduler choice is subtle across yield and k_sleep(), add calls to
those to the state table and validate that we're making the right
decisions.
Signed-off-by: Andy Ross [email protected]