Skip to content

stm32 flash read out protection rdp in a common file #81876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Nov 25, 2024

Following the PR "Implement readout protection for STM32H7" #76640, it appears that
" Function flash_stm32_option_bytes_lock() seems to be the obvious candidate to be moved to" a common file to stm32h7 anr other stm32 series.
This common file could be the existing drivers/flash/flash_stm32_ex_op.c
The flash_stm32_option_bytes_lock() is moved there and the flash_stm32_write_protection is made external to that file

@FRASTM FRASTM added platform: STM32 ST Micro STM32 area: Flash DNM This PR should not be merged (Do Not Merge) labels Nov 25, 2024
@FRASTM FRASTM force-pushed the stm32h7_rdp_common branch 3 times, most recently from 837931e to 31efa57 Compare December 2, 2024 13:36
@FRASTM FRASTM force-pushed the stm32h7_rdp_common branch from 31efa57 to 900408b Compare December 9, 2024 15:42
@FRASTM
Copy link
Collaborator Author

FRASTM commented Dec 9, 2024

PR #76640 is now merged, rebase on 4488ed1

@FRASTM FRASTM removed the DNM This PR should not be merged (Do Not Merge) label Dec 9, 2024
@FRASTM FRASTM marked this pull request as ready for review December 9, 2024 15:45
Copy link

github-actions bot commented Feb 8, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 8, 2025
@JarmouniA JarmouniA removed the Stale label Feb 9, 2025
@JarmouniA JarmouniA added this to the v4.1.0 milestone Feb 9, 2025
@fabiobaltieri fabiobaltieri modified the milestones: v4.1.0, v4.2.0 Mar 6, 2025
@FRASTM FRASTM force-pushed the stm32h7_rdp_common branch from 900408b to 75fef9a Compare March 6, 2025 16:12
@zephyrbot zephyrbot requested a review from djiatsaf-st March 6, 2025 16:12
@FRASTM
Copy link
Collaborator Author

FRASTM commented Mar 6, 2025

rebased on 0717698

Move the flash_stm32_write_protection and
flash_stm32_option_bytes_lock functions to a common
file for stm32 devices including stm32h7

Signed-off-by: Francois Ramu <[email protected]>
@FRASTM FRASTM force-pushed the stm32h7_rdp_common branch from 75fef9a to 354c035 Compare March 18, 2025 09:36
@FRASTM
Copy link
Collaborator Author

FRASTM commented Mar 18, 2025

rebase on 3d2059f

@FRASTM FRASTM closed this Mar 18, 2025
@FRASTM FRASTM reopened this Mar 18, 2025
@erwango
Copy link
Member

erwango commented Mar 21, 2025

^^@duda-patryk, @niedzwiecki-dawid

@FRASTM
Copy link
Collaborator Author

FRASTM commented Apr 25, 2025

^^@duda-patryk, @niedzwiecki-dawid

kind reminder

regs->OPTCR |= FLASH_OPTCR_OPTLOCK;
} else if (regs->OPTCR & FLASH_OPTCR_OPTLOCK) {
regs->OPTKEYR = FLASH_OPT_KEY1;
regs->OPTKEYR = FLASH_OPT_KEY2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants