Skip to content

lib: smf: mark as unstable #83644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: smf: mark as unstable #83644

wants to merge 1 commit into from

Conversation

maass-hamburg
Copy link
Collaborator

mark State Machine Framework API as unstable,
as it is now used by usb-c and hawkBit.

As noted here: #71675 (comment)

@maass-hamburg
lib: smf: mark as unstable
d7d8f17 
mark State Machine Framework API as unstable,
as it is now used by usb-c and hawkBit.

Signed-off-by: Fin Maaß <[email protected]>
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: State Machine Framework State Machine Framework labels Jan 7, 2025
glenn-andrews
glenn-andrews approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@glenn-andrews glenn-andrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@glenn-andrews
Copy link
Collaborator

TBH I would love to refactor the API for this, but now two modules use it I'm scared to.

@henrikbrixandersen
Copy link
Member

TBH I would love to refactor the API for this, but now two modules use it I'm scared to.

Those are just the in-tree users.

@glenn-andrews
Copy link
Collaborator

TBH I would love to refactor the API for this, but now two modules use it I'm scared to.

Those are just the in-tree users.

Yeah, I know. I put in an RFC here: #83659

@maass-hamburg
Copy link
Collaborator Author

ping @sambhurst

@kartben kartben mentioned this pull request Jan 16, 2025
Open
@glenn-andrews
Copy link
Collaborator

We've had a request for the work here to be landed, as well as the follow-up work to make transitions a return code, before marking this as Unstable.

@henrikbrixandersen henrikbrixandersen added the DNM This PR should not be merged (Do Not Merge) label Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 2, 2025
@glenn-andrews
Copy link
Collaborator

Still on hold for #83854 to land and follow-up work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@glenn-andrews glenn-andrews glenn-andrews approved these changes

@keith-zephyr keith-zephyr keith-zephyr approved these changes

@sambhurst sambhurst Awaiting requested review from sambhurst

Assignees

@sambhurst sambhurst

Labels
area: State Machine Framework State Machine Framework DNM This PR should not be merged (Do Not Merge) size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maass-hamburg @glenn-andrews @henrikbrixandersen @kartben @keith-zephyr @zephyrbot @sambhurst