drivers: sensor: temperature: Add i.MX RT die temperature sensor #83880

anedergaard · 2025-01-13T07:59:09Z

Added dts binding for die temperature sensor for i.MX RT117X and i.MX RT118X
Added driver for die temperature readings on i.MX RT117X and i.MX RT118X
Added overlay file for RT1170-EVK in temp_sensor test for validation

zephyrbot · 2025-01-13T08:00:13Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dts/bindings/sensor/nxp,imxrt-tmpsns.yaml

jeppenodgaard

Functionality LGTM.
I think some naming alignment is needed. There's tmpsns, temp, temperature.

drivers/sensor/nxp/nxp_imxrt_temp/temp_imxrt.c

anedergaard · 2025-01-14T07:43:33Z

Functionality LGTM. I think some naming alignment is needed. There's tmpsns, temp, temperature.

Yes, you are right, I'll align the naming once @DerekSnell has suggested a compatible string.

DerekSnell · 2025-01-14T16:31:47Z

Hi @anedergaard ,
Thank you for this contribution, and for getting guidance on the naming. As @decsny stated, NXP does not like to use SOC or SOC family names in the bindings and drivers, because the hardware IP is frequently re-used across the portfolio on other familes.

The IP name for this HW peripheral is TMPSNS, which is also the name used in the SOC reference manual, and in the HAL driver fsl_tempsensor.c. So I think the best name for this binding is nxp,tmpsns.

Thank you

anedergaard · 2025-01-14T20:57:32Z

Hi @DerekSnell,
Thank you for the feedback on naming and the reasoning behind it - I appreciate it!

Updated 1

Addressed driver naming, renamed binding to nxp,tmpsns
Rebased to address conflicts

anedergaard · 2025-01-14T21:08:42Z

Update 2:

Addressed compliance issue on Kconfig source order.

MaureenHelm · 2025-01-15T14:25:16Z

drivers/sensor/nxp/nxp_tmpsns/Kconfig

+	depends on SOC_SERIES_IMXRT11XX || SOC_SERIES_IMXRT118X
+	default y
+	help
+		Enable temperature measurement for NXP TMPSNS sensor


Suggested change

Enable temperature measurement for NXP TMPSNS sensor

Enable temperature measurement for NXP TMPSNS sensor

MaureenHelm · 2025-01-15T14:27:26Z

drivers/sensor/nxp/nxp_tmpsns/nxp_tmpsns.c

+	}
+}
+
+static const struct sensor_driver_api tmpsns_driver_api = {


Suggested change

static const struct sensor_driver_api tmpsns_driver_api = {

static DEVICE_API(sensor, tmpsns_driver_api) = {

tests/drivers/sensor/temp_sensor/boards/mimxrt1170_evk_mimxrt1176_cm7.overlay

jeppenodgaard

Naming looks good :)

jeppenodgaard · 2025-01-15T14:39:01Z

drivers/sensor/nxp/nxp_tmpsns/nxp_tmpsns.c

+	const struct nxp_tmpsns_data *data = dev->data;
+
+	switch (chan) {
+	case SENSOR_CHAN_ALL:


Delete this line.
get cannot support SENSOR_CHAN_ALL since there is only one val reference.

DerekSnell

Hi @anedergaard ,

Thank you for contributing this. I am blocking to address this build warning when I build the test for the MIMXRT1170-EVK. The test does build and runs well on my board. But can you improve the DTS to avoid this warning?

CMake Warning at 
/zephyrproject/zephyr/cmake/modules/dts.cmake:425 (message):
  dtc raised one or more warnings:
 
  /build/zephyr/zephyr.dts:4051.27-4054.5:
  Warning (simple_bus_reg): /soc/temp: missing or empty reg/ranges property

Otherwise, the naming changes you made look good to me.

I see your PR got caught in a known CI issue with the RT1180, which should be resolved when #83827 merges.

A very minor nit, but since you will be updating - there is a typo in commit message "termerature"

Thank you

dts/bindings/sensor/nxp,tmpsns.yaml

MaureenHelm · 2025-01-20T21:42:51Z

drivers/sensor/nxp/nxp_tmpsns/CMakeLists.txt

@@ -0,0 +1,3 @@
+zephyr_library()


File needs a license/copyright header

mmahadevan108 · 2025-01-22T22:17:20Z

drivers/sensor/nxp/nxp_tmpsns/Kconfig

+	bool "NXP TMPSNS sensor"
+	depends on SENSOR
+	depends on DT_HAS_NXP_TMPSNS_ENABLED
+	depends on SOC_SERIES_IMXRT11XX || SOC_SERIES_IMXRT118X


Do we need this depends. Is'nt is sufficient to base it on if the temperature sensor is enabled in device tree.

mmahadevan108 · 2025-01-22T22:34:16Z

drivers/sensor/nxp/nxp_tmpsns/nxp_tmpsns.c

+	switch (chan) {
+	case SENSOR_CHAN_ALL:
+	case SENSOR_CHAN_DIE_TEMP:
+		data->die_temp = TMPSNS_GetCurrentTemperature(TMPSNS);


You should be getting the base address from device tree.

mmahadevan108 · 2025-01-22T22:34:49Z

dts/arm/nxp/nxp_rt118x.dtsi

+
+	soc {
+		temp: temp {
+			compatible = "nxp,tmpsns";


Need to add base address and interrupt properties. Also this should be part of the peripheral block

mmahadevan108 · 2025-01-22T22:35:17Z

dts/arm/nxp/nxp_rt11xx.dtsi

@@ -1307,6 +1307,11 @@
 				status = "disabled";
 			};
 		};
+
+		temp: temp {
+			compatible = "nxp,tmpsns";


Missing base and interrupt properties

yperess · 2025-01-23T05:41:12Z

drivers/sensor/nxp/nxp_tmpsns/nxp_tmpsns.c

+#include <zephyr/drivers/sensor.h>
+
+struct nxp_tmpsns_data {
+	float die_temp;


If you're going to use a float instead of the q31 format you should depend on FPU

yperess · 2025-01-23T05:43:13Z

drivers/sensor/nxp/nxp_tmpsns/nxp_tmpsns.c

+	config.measureMode = kTEMPSENSOR_ContinuousMode;
+	config.frequency = 0x03U;
+	TMPSNS_Init(TMPSNS, &config);
+	TMPSNS_StartMeasure(TMPSNS);


Is it necessary to start measuring on init? Why not enable the attribute for sample frequency to start sampling?

anedergaard · 2025-01-27T10:38:44Z

Thanks for the review feedback, I appreciate it.
I'll look into the requested changes.

github-actions · 2025-04-06T00:39:03Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

decsny · 2025-04-14T16:04:04Z

@anedergaard any update for this PR?

anedergaard · 2025-04-15T14:44:42Z

@anedergaard any update for this PR?

Hi @decsny, sorry for stalling this PR.

I will address the hal_nxp SDK-NG changes first, then address the changes requested for this PR

Added die temperature binding for i.MX RT 117X and i.MX RT 118X Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

Added driver for i.MX RT117X and i.MX RT118X die temperature sensor Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

…-EVK Added temp_sensor overlay for i.MX RT1170-EVK & RT1180-EVK Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

anedergaard · 2025-04-20T12:23:49Z

Update: Moved to use hal_nxp SDK-NG

zephyrbot added area: Sensors Sensors platform: NXP NXP platform: NXP Drivers NXP Semiconductors, drivers labels Jan 13, 2025

zephyrbot requested review from asemjonovs, avisconti, dbaluta, decsny, DerekSnell, dleach02, jeppenodgaard, manuargue, MaureenHelm, mmahadevan108, teburd, tristan-google, ubieda, yperess and yvanderv January 13, 2025 07:59

zephyrbot assigned MaureenHelm Jan 13, 2025

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 13, 2025

anedergaard force-pushed the driver-tmpsns-imxrt11xx branch from 353c9e1 to ab9fb98 Compare January 13, 2025 08:24

decsny reviewed Jan 13, 2025

View reviewed changes

dts/bindings/sensor/nxp,imxrt-tmpsns.yaml Outdated Show resolved Hide resolved

jeppenodgaard requested changes Jan 13, 2025

View reviewed changes

drivers/sensor/nxp/nxp_imxrt_temp/temp_imxrt.c Outdated Show resolved Hide resolved

drivers/sensor/nxp/nxp_imxrt_temp/temp_imxrt.c Outdated Show resolved Hide resolved

drivers/sensor/nxp/nxp_imxrt_temp/temp_imxrt.c Outdated Show resolved Hide resolved

anedergaard force-pushed the driver-tmpsns-imxrt11xx branch 2 times, most recently from 42f9cdc to 9b87ba0 Compare January 14, 2025 20:55

anedergaard force-pushed the driver-tmpsns-imxrt11xx branch from 9b87ba0 to b891f14 Compare January 14, 2025 21:07

MaureenHelm requested changes Jan 15, 2025

View reviewed changes

jeppenodgaard requested changes Jan 15, 2025

View reviewed changes

DerekSnell requested changes Jan 15, 2025

View reviewed changes

anedergaard force-pushed the driver-tmpsns-imxrt11xx branch from b891f14 to 783ed44 Compare January 20, 2025 21:11

MaureenHelm requested changes Jan 20, 2025

View reviewed changes

mmahadevan108 requested changes Jan 22, 2025

View reviewed changes

yperess requested changes Jan 23, 2025

View reviewed changes

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

github-actions bot added the Stale label Apr 6, 2025

decsny removed the Stale label Apr 14, 2025

anedergaard added 3 commits April 17, 2025 08:02

dts: bindings: Add nxp i.MX RT die temperature binding

97c044a

Added die temperature binding for i.MX RT 117X and i.MX RT 118X Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

drivers: sensor: temperature: Add i.MX RT die temperature sensor

8a64293

Added driver for i.MX RT117X and i.MX RT118X die temperature sensor Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

tests: drivers: temp_sensor: Add overlay for i.MX RT1170-EVK & RT1180…

693aee3

…-EVK Added temp_sensor overlay for i.MX RT1170-EVK & RT1180-EVK Signed-off-by: Anders Bjørn Nedergaard <[email protected]>

anedergaard force-pushed the driver-tmpsns-imxrt11xx branch from 783ed44 to 693aee3 Compare April 20, 2025 12:21

github-actions bot removed manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Apr 20, 2025

anedergaard mentioned this pull request Apr 20, 2025

drivers: Add mcux drivers for TMPSNS used by i.MX RT11XX zephyrproject-rtos/hal_nxp#494

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: sensor: temperature: Add i.MX RT die temperature sensor #83880

drivers: sensor: temperature: Add i.MX RT die temperature sensor #83880

anedergaard commented Jan 13, 2025

zephyrbot commented Jan 13, 2025 •

edited by github-actions bot

Loading

jeppenodgaard left a comment

anedergaard commented Jan 14, 2025

DerekSnell commented Jan 14, 2025

anedergaard commented Jan 14, 2025

anedergaard commented Jan 14, 2025

MaureenHelm Jan 15, 2025

MaureenHelm Jan 15, 2025

jeppenodgaard left a comment

jeppenodgaard Jan 15, 2025

DerekSnell left a comment

MaureenHelm Jan 20, 2025

mmahadevan108 Jan 22, 2025

mmahadevan108 Jan 22, 2025

mmahadevan108 Jan 22, 2025

mmahadevan108 Jan 22, 2025

yperess Jan 23, 2025

yperess Jan 23, 2025

anedergaard commented Jan 27, 2025

github-actions bot commented Apr 6, 2025

decsny commented Apr 14, 2025

anedergaard commented Apr 15, 2025

anedergaard commented Apr 20, 2025

	Enable temperature measurement for NXP TMPSNS sensor
	Enable temperature measurement for NXP TMPSNS sensor

	static const struct sensor_driver_api tmpsns_driver_api = {
	static DEVICE_API(sensor, tmpsns_driver_api) = {

drivers: sensor: temperature: Add i.MX RT die temperature sensor #83880

Are you sure you want to change the base?

drivers: sensor: temperature: Add i.MX RT die temperature sensor #83880

Conversation

anedergaard commented Jan 13, 2025

zephyrbot commented Jan 13, 2025 • edited by github-actions bot Loading

jeppenodgaard left a comment

Choose a reason for hiding this comment

anedergaard commented Jan 14, 2025

DerekSnell commented Jan 14, 2025

anedergaard commented Jan 14, 2025

anedergaard commented Jan 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeppenodgaard left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DerekSnell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anedergaard commented Jan 27, 2025

github-actions bot commented Apr 6, 2025

decsny commented Apr 14, 2025

anedergaard commented Apr 15, 2025

anedergaard commented Apr 20, 2025

zephyrbot commented Jan 13, 2025 •

edited by github-actions bot

Loading