-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Introduce Bouffalo Lab SoC's [patch 1] #84173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Bouffalo Lab SoC's [patch 1] #84173
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
6cbbaa4
to
c0018bb
Compare
Hi Nandovje |
Hi @profound1987 , Nice to talk with you again : ) Is the lhal a result from bouffalolab/bouffalo_sdk#14 request ? We have a RFC #83663 that gives some directions about how we would like proceed. This is the first step to add Bouffalo Lab vendor in Zephyr mainline. Last week we got green light to have the
We are always open to talk. Send me pvt email to us schedule a meeting. |
Hi @nandojve I notice that the driver that you are using is https://github.com/bouffalolab/bouffalo_sdk/tree/release_v1.4.5, it's out of date for long time, we really sorry for that we have not update bouffalo sdk release, the current code on master branch is based on lhal, you can take a look. I will also do a release on bouffalo sdk. |
Hello @profound1987 , please refer to the RFC at #83663 for further discussions. Here is the first PR of many and not the place to discuss general Bouffalolab support. There is also a brand new vendor channel in the Zephyr discord if you want to discuss this more instantly. Further Details (and answers to your message) will be dispatched on the RFC at #83663. |
c0018bb
to
b53eb5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some early observations.
BFLB_USE_CUSTOM_LD_SECTIONS | ||
) | ||
|
||
set(bflb_soc bl602) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an observation, but this decouples the passed to the hal from the SoC described by the soc.yml and in Kconfig, which in future can make it harder to find / handle if support for other bouffalo SoCs is introduced.
Not a request to change now, but please consider if this could be improved if addressing other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. It will be improved soon on other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this header being included anywhere.
Can you please provide some more info ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is defined to replace the default sections inside the drivers functions inside HAL. There is an improvement planned to remove all this.
b53eb5d
to
1192d6d
Compare
b0dc826
to
c85ae38
Compare
Add initial version that uses bouffalo_sdk 1.4.5. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add necessary bflb prefix to be used on devicetree bindings and identify the board vendor. Signed-off-by: Gerson Fernando Budke <[email protected]>
Introduce Bouffalo Lab vendor with BL60x cpu. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add initial version. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add Bouffalo Lab pinctrl driver. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add Bouffalo Lab serial driver. The driver uses pinctrl to configure pins and have power management capabilities. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add initial version. Signed-off-by: Gerson Fernando Budke <[email protected]>
c85ae38
to
c27eefd
Compare
c27eefd
to
ff960ed
Compare
Introduce Bouffalo Lab platform. Signed-off-by: Gerson Fernando Budke <[email protected]>
ff960ed
to
2770da0
Compare
The manifest is up to date but BOT is not removing the DNM label (manifest) |
Just one minor, but IMO blocking, nit in the west flasher, otherwise this looks great to me! Awesome stuff @nandojve , amazing persistence working on this
The content was removed. A convenience tool will be introduced later.
Hi @tejlmand, Could you revisit to confirm that your concerns were addressed. |
Added DNM to give @mbolivar time to respond as per our processes. |
This PR is intent to continue the work started at #37686. It rewrite the original work to be compatible with Zephyr 4.1.
This is the first PR of a series, which includes:
* Add bfflash runner to easy flashThis is an split of #78795
RFC of reference: #83663