spi_nxp_lpspi: Save RAM by having driver data ptr #84406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a pointer to data that is specific to a certain type of LPSPI driver, instead of having all of it in the struct whether it is used or not. Signed-off-by: Declan Snyder <[email protected]>
zephyrbot
added
area: SPI
zephyrbot
requested review from
dbaluta,
dleach02,
manuargue,
mmahadevan108,
tbursztyka and
teburd
EmilioCBen
approved these changes
Jan 23, 2025
tbursztyka
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit in this PR combines two of the commits in #82877 , just splitting this off to make that PR simpler since it is technically not required for the main idea of that PR. This should merge first.
What this does is remove a lot of stuff from the lpspi data struct and replace them with a void* to driver-specific data, meaning, ie, there are multiple distinct lpspi driver files now, and these paths do not actually share data types, so having all these datas in the common data structure is a waste of space.