spi_nxp_lpspi: Fix chip select bug when using RTIO and reduce maintenance overhead #84931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP
zephyrbot
requested review from
butok,
Dat-NguyenDuy,
dbaluta,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
JiafeiPan,
manuargue,
mmahadevan108,
tbursztyka and
teburd
decsny
force-pushed
the
feature/lpspi_enhancements_5
branch
from
54e1f09 to
a0d3dbc
Compare
For the CPU-based drivers, delete the old MCUX based RTIO driver and use the default RTIO submit implementation instead. Rationale: - 300 LOC -> 1 LOC to maintain. - MCUX SDK based driver cannot control the chip select for the transfer properly, but the new spi_nxp_lpspi.c driver can. So this fixes the bug with the PCS when using RTIO. Also enable the default RTIO implementation for DMA based driver. In the future a DMA based RTIO driver with custom implementation can be designed, but for CPU based transfer, which is already not optimal performance, code maintenance is more important. Only requirement is asynchronous submit, which is accomplished by p4wq in rtio workq. Signed-off-by: Declan Snyder <[email protected]>
decsny
force-pushed
the
feature/lpspi_enhancements_5
branch
from
a0d3dbc to
02df780
Compare
|
"MCUX SDK based driver cannot control the chip select for the transfer |
mmahadevan108
approved these changes
Feb 3, 2025
no, the SDK driver is just made for single buffer transfer, so it works when doing that, but we can't use that API with zephyr |
EmilioCBen
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the CPU-based drivers, delete the old MCUX based RTIO driver and use
the default RTIO submit implementation instead.
Rationale:
properly, but the new spi_nxp_lpspi.c driver can. So this fixes the
bug with the PCS when using RTIO.
In the future a custom DMA based RTIO driver with custom implementation can be
designed, but for CPU based transfers, which is already not optimal
performance, code maintenance is more important. Only requirement is
asynchronous submit, which is accomplished by p4wq in rtio workq.
Also enables default RTIO submit for SPI with DMA driver now that refactor was done.
Depends on #82877