drivers: serial: nrfx_uarte: Add workaround for FRAMETIMEOUT corner case #85392
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: nRF
zephyrbot
requested review from
anangl,
dcpleung,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
|
@anangl can you take a look? |
bjarki-andreasen
previously approved these changes
Mar 20, 2025
anangl
reviewed
Mar 20, 2025
| @@ -1611,6 +1649,12 @@ static void rxto_isr(const struct device *dev) | |||
| struct uarte_nrfx_data *data = dev->data; | |||
| struct uarte_async_rx *async_rx = &data->async->rx; | |||
|
|
|||
| if (IS_ENABLED(RX_FRAMETIMEOUT_WORKAROUND)) { | |||
| if (atomic_test_and_clear_bit(&data->flags, UARTE_FLAG_FTIMEOUT_WATCH)) { | |||
There was a problem hiding this comment.
Suggested change
| if (atomic_test_and_clear_bit(&data->flags, UARTE_FLAG_FTIMEOUT_WATCH)) { | |
| if (atomic_test_and_clear_bit(&data->flags, UARTE_FLAG_FTIMEOUT_WATCH_BIT)) { |
But perhaps it would be better, for consistency with other flags, to not use UARTE_FLAG_FTIMEOUT_WATCH_BIT at all, just UARTE_FLAG_FTIMEOUT_WATCH and atomic_and().
When reception is restarted (STARTRX after ENDRX but no STOPRX) it is possible that FRAMETIMEOUT countdown counter will not be started by the first received byte if byte was already being transmitted when STARTRX was called. If that is the only byte then it is expected that timeout will be triggered but since FRAMETIMEOUT counter is not started there is no FRAMETIMEOUT event which has short to STOPRX. This situation will happen in case short buffers are used (< 5 bytes) because then short ENDRX_STARTRX is not used then. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
nrfx_uarte_frametimeout_workaround
branch
from
4caae37 to
f76b9f8
Compare
bjarki-andreasen
approved these changes
Mar 21, 2025
|
@anangl can you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reception is restarted (STARTRX after ENDRX but no STOPRX) it is possible that FRAMETIMEOUT countdown counter will not be started by the first received byte if byte was already being transmitted when STARTRX was called. If that is the only byte then it is expected that timeout will be triggered but since FRAMETIMEOUT counter is not started there is no FRAMETIMEOUT event which has short to STOPRX. This situation will happen in case short buffers are used (< 5 bytes) because then short ENDRX_STARTRX is not used then.