-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Enabling IW416 and IW612 BT HCI controller with MIMXRT1060EVKC platform for Bluetooth apps to work #85639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling IW416 and IW612 BT HCI controller with MIMXRT1060EVKC platform for Bluetooth apps to work #85639
Conversation
Hello @nirav-agrawal, and thank you very much for your first pull request to the Zephyr project! |
5809bbb
to
cfb1eee
Compare
cfb1eee
to
1f76e40
Compare
1f76e40
to
7bb74fc
Compare
|
||
This Zephyr shield is tested with the following M.2 modules and hardware for Wi-Fi and Bluetooth applications: | ||
- Embedded Artist 1XK module - uses Murata 1XK radio module with NXP IW416 chipset | ||
- Embedded Artist 2EL module - uses Murata 2EL radio module with NXP IW612 chipset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be the improper indent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error is at line 50. But I can remove extra space and recheck this. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah still not ok :) please see my comment
Bullet lists need to be preceded by an empty line
5471da4
to
eab146f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shield doc needs some love - see CI build here https://builds.zephyrproject.io/zephyr/pr/85639/docs/boards/shields/nxp_m2_wifi_bt/doc/index.html
Thanks!
This Zephyr shield is tested with the following M.2 modules and hardware for Wi-Fi and Bluetooth applications: | ||
- Embedded Artist 1XK module - uses Murata 1XK radio module with NXP IW416 chipset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Zephyr shield is tested with the following M.2 modules and hardware for Wi-Fi and Bluetooth applications: | |
- Embedded Artist 1XK module - uses Murata 1XK radio module with NXP IW416 chipset | |
This Zephyr shield is tested with the following M.2 modules and hardware for Wi-Fi and Bluetooth applications: | |
- Embedded Artist 1XK module - uses Murata 1XK radio module with NXP IW416 chipset |
`IW612 NXP Chipset <https://www.nxp.com/products/IW612>`_ | ||
`IW416 NXP Chipset <https://www.nxp.com/products/IW416>`_ | ||
`2EL Murata Radio Module <https://www.murata.com/en-us/products/connectivitymodule/wi-fi-bluetooth/overview/lineup/type2el>`_ | ||
`1XK Murata Radio Module <https://www.murata.com/en-us/products/connectivitymodule/wi-fi-bluetooth/overview/lineup/type1xk>`_ | ||
`1XK Embedded Artist Module <https://www.embeddedartists.com/products/1xk-m-2-module>`_ | ||
`2EL Embedded Artist Module <https://www.embeddedartists.com/products/2el-m-2-module>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a proper bullet list - see here how it looks like currently https://builds.zephyrproject.io/zephyr/pr/85639/docs/boards/shields/nxp_m2_wifi_bt/doc/index.html
- nxp_m2_1xk_wifi_bt : For Wi-Fi/Bluetooth samples to work with NXP IW416 SoC | ||
- nxp_m2_2el_wifi_bt : For Wi-Fi/Bluetooth samples to work with NXP IW612 SoC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- nxp_m2_1xk_wifi_bt : For Wi-Fi/Bluetooth samples to work with NXP IW416 SoC | |
- nxp_m2_2el_wifi_bt : For Wi-Fi/Bluetooth samples to work with NXP IW612 SoC | |
- ``nxp_m2_1xk_wifi_bt``: For Wi-Fi/Bluetooth samples to work with NXP IW416 SoC | |
- ``nxp_m2_2el_wifi_bt``: For Wi-Fi/Bluetooth samples to work with NXP IW612 SoC |
eab146f
to
6a3cc42
Compare
@nirav-agrawal, I applied the changes @kartben requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for docs/shield, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @nirav-agrawal . Thanks for all your work on this.
- Added new shield to add support for WIFI and BT interface. - Added board overlay for MIMXRT1060EVKC. - Removed mimxrt1062 overlay from shell example to avoid conflicts. - Added seperate shield overlay for supported M.2 module to enable BT or WIFI or Both. - Added default kconfigs for each BT and WIFI which enables supported modules and SoC as part of enabled shield through build param. - Added shield document. Signed-off-by: Nirav Agrawal <[email protected]>
1604108
6a3cc42
to
1604108
Compare
This PR has below updates,
1. Enabled IW416 (with Murata 1XK M2 module) SoC to work with BT HCI driver, perform BT only firmware download using NXP HCI Driver.
a. Adding Firmware blobs and nxp_hal related changes are done to fetch the firmware, perform .bin to .inc conversion, and
include it in inclusion list. We will update west manifest with both PRs once it gets raised here.
2. Enabled MIMXRT1060EVKC platform works with IW416/IW612 controller M2 modules (1XK/2EL) with help of new shield.
a. "nxp_m2_wifi_bt" shield has an overlay which is required for WIFI SDIO and BT HCI driver attachment for both IW416 and IW612
controllers. To support this shield for other platform, board overlay should be added similar to RT1060EVKC overlay which
expose platform specific pin-mux details.
3. Added required kconfigs for Bluetooth samples to work on iMXRT platforms without any initial crashes like stack overflows from various tasks.
This PR has dependency on zephyrproject-rtos/hal_nxp#512. This PR needs to be merged after hal_nxp/PR#512.
Regards,
Nirav