-
Notifications
You must be signed in to change notification settings - Fork 7.3k
drivers: memc: memc_nxp_flexram.h: Move to the public includes directory #85954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kartben
merged 2 commits into
zephyrproject-rtos:main
from
nxp-upstream:move_memc_nxp_flexram.h
Apr 26, 2025
Merged
drivers: memc: memc_nxp_flexram.h: Move to the public includes directory #85954
kartben
merged 2 commits into
zephyrproject-rtos:main
from
nxp-upstream:move_memc_nxp_flexram.h
Apr 26, 2025
+82
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decsny
previously approved these changes
Feb 18, 2025
kartben
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to update 4.2 migration guide instead. Thanks!
dc84eb7
to
31d5e32
Compare
update:
|
31d5e32
to
485fb60
Compare
dleach02
reviewed
Apr 21, 2025
kartben
reviewed
Apr 23, 2025
485fb60
to
f389c7a
Compare
Moved to: include/zephyr/drivers/misc/flexram/memc_nxp_flexram.h This change makes it so that the .h file does not need to be pulled in using the CMakeLists.txt file, and can be included like other public includes. Removes drivers/memc/memc_nxp_flexram.h Add memc_nxp_flexram.h to include/zephyr/drivers/misc/flexram Modify drivers/memc/memc_nxp_flexram.c to use the new include path. Modifies the mimxrt1170 magic_addr sample to include the driver using the new include path. Modify the soc file: soc/nxp/imxrt/imxrt11xx/soc.c to use the new path. Add relevant information to migration-guide-4.2.rst. Signed-off-by: Jacob Wienecke <[email protected]> Co-authored-by: Declan Snyder <[email protected]>
Flexram is really not a memory controller, and does not belong in memc namespace or directory. Move it to it's own misc directory and remove memc_ from the namespace. Signed-off-by: Declan Snyder <[email protected]>
f389c7a
to
8fd98d2
Compare
decsny
approved these changes
Apr 25, 2025
dleach02
approved these changes
Apr 25, 2025
kartben
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: MEMC
area: Samples
Samples
platform: NXP Drivers
NXP Semiconductors, drivers
platform: NXP
NXP
Release Notes
To be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to: include/zephyr/drivers/misc/flexram/memc_nxp_flexram.h
This change makes it so that the .h file does not need to be pulled in using the CMakeLists.txt file and can be included like other public includes.
Removes drivers/memc/memc_nxp_flexram.h
Add memc_nxp_flexram.h to include/zephyr/drivers/misc/flexram
Modify drivers/memc/memc_nxp_flexram.c to use the new include path.
Modify the mimxrt1170 magic_addr sample to include the driver using the new include path.
Modify the soc file: soc/nxp/imxrt/imxrt11xx/soc.c to use the new path.
Add relevant information to migration-guide-4.1.rst.