Skip to content

drivers: memc: memc_nxp_flexram.h: Move to the public includes directory #85954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

jacob-wienecke-nxp
Copy link
Contributor

Moved to: include/zephyr/drivers/misc/flexram/memc_nxp_flexram.h

This change makes it so that the .h file does not need to be pulled in using the CMakeLists.txt file and can be included like other public includes.

Removes drivers/memc/memc_nxp_flexram.h

Add memc_nxp_flexram.h to include/zephyr/drivers/misc/flexram

Modify drivers/memc/memc_nxp_flexram.c to use the new include path.

Modify the mimxrt1170 magic_addr sample to include the driver using the new include path.

Modify the soc file: soc/nxp/imxrt/imxrt11xx/soc.c to use the new path.

Add relevant information to migration-guide-4.1.rst.

decsny
decsny previously approved these changes Feb 18, 2025
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to update 4.2 migration guide instead. Thanks!

@decsny decsny force-pushed the move_memc_nxp_flexram.h branch 2 times, most recently from dc84eb7 to 31d5e32 Compare March 19, 2025 15:44
@decsny
Copy link
Member

decsny commented Mar 19, 2025

update:

  • rebase
  • fix migration guide
  • fix bug where rt10xx soc.c did not have the update to the header
  • change include file name to "nxp_flexram.h" instead of "memc_nxp_flexram.h" since it was being put in the misc directory, the namespace of memc didn't make sense
  • move the .c file also to a misc driver directory and move all flexram things out of memc
  • remove memc namespace from all API and kconfig

@decsny decsny force-pushed the move_memc_nxp_flexram.h branch from 31d5e32 to 485fb60 Compare April 3, 2025 18:59
@decsny decsny requested a review from kartben April 3, 2025 18:59
@fabiobaltieri fabiobaltieri removed their assignment Apr 10, 2025
@kartben kartben removed their assignment Apr 23, 2025
jacob-wienecke-nxp and others added 2 commits April 24, 2025 15:18
Moved to: include/zephyr/drivers/misc/flexram/memc_nxp_flexram.h

This change makes it so that the .h file does not need to be pulled in
using the CMakeLists.txt file, and can be included like other public
includes.

Removes drivers/memc/memc_nxp_flexram.h

Add memc_nxp_flexram.h to include/zephyr/drivers/misc/flexram

Modify drivers/memc/memc_nxp_flexram.c to use the new include path.

Modifies the mimxrt1170 magic_addr sample to include the driver using
the new include path.

Modify the soc file: soc/nxp/imxrt/imxrt11xx/soc.c to use the new path.

Add relevant information to migration-guide-4.2.rst.

Signed-off-by: Jacob Wienecke <[email protected]>
Co-authored-by: Declan Snyder <[email protected]>
Flexram is really not a memory controller, and does not belong in memc
namespace or directory. Move it to it's own misc directory and remove
memc_ from the namespace.

Signed-off-by: Declan Snyder <[email protected]>
@kartben kartben merged commit e358713 into zephyrproject-rtos:main Apr 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: MEMC area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants