drivers: counter: Fix MAX32 counter timer driver #85993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counter is set to zero when it is started. Relative alarm irq_on_late and max_rel_val is added to be able to run test_short_relative_alarm. Signed-off-by: Anıl Kara <[email protected]>
zephyrbot
requested review from
galak,
MaureenHelm,
microbuilder,
nordic-krch,
ozersa,
ttmut and
yasinustunerg
ttmut
reviewed
Feb 19, 2025
| @@ -44,6 +44,7 @@ static int api_start(const struct device *dev) | |||
| const struct max32_tmr_config *cfg = dev->config; | |||
|
|
|||
| Wrap_MXC_TMR_EnableInt(cfg->regs); | |||
| MXC_TMR_SetCount(cfg->regs, 0); | |||
There was a problem hiding this comment.
I am not sure if counter value should be reset in counter_start.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets counter to zero when it is started and adds relative alarm irq_on_late and max_rel_val to be able to run test_short_relative_alarm.
Signed-off-by: Anıl Kara [email protected]
Signed-off-by: Furkan Akkiz [email protected]