lwm2m: Do not enforce canonical CBOR deconding #86083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
approved these changes
Feb 20, 2025
rlubos
previously approved these changes
Feb 20, 2025
nordicjm
reviewed
Feb 21, 2025
Our decoder can handle decoding of non-deterministic CBOR just fine. There is no need to block valid CBOR if the server does not produce length-first deterministic CBOR. Signed-off-by: Seppo Takalo <[email protected]>
SeppoTakalo
force-pushed
the
lwm2m_cbor_canonical
branch
from
ec366a6 to
aba6f78
Compare
|
I dropped the MCUmgr part from this PR. That should be fixed separately. For LwM2M, we don't control both sides, so allow non-canonical. |
SeppoTakalo
changed the title
SeppoTakalo
requested review from
oyvindronningstad and
rlubos
and removed request for
oyvindronningstad
rlubos
approved these changes
Mar 3, 2025
jukkar
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving CBOR encoded data, we do not need to enforce canonical decoding.
See: https://github.com/zephyrproject-rtos/zephyr/pull/82318/files