net: Add timeout to various send functions #86127

clamattia · 2025-02-21T08:13:12Z

Add timeout to various send function. To keep stable API, functions are renamed with _try-prefix. Original functions just call the _try-variant with timeout K_FOREVER.

Fixes: #85981

Timeout can be used to early drop some request for arp and icmp to avoid being slowed when in a flood situation.

Looking forward to your thoughts.

rlubos

I think we could go this way if we retain stable APIs compability.

subsys/net/ip/net_core.c

clamattia · 2025-02-21T10:19:45Z

Created separate commits for introducing timeout and using it
made original functions static inline as suggested by @pdgendt
For now I added timeout for net_context, arp, icmp, lldp

rlubos · 2025-02-21T11:06:03Z

subsys/net/ip/net_context.c

@@ -2609,7 +2609,7 @@ static int context_sendto(struct net_context *context,
 			net_pkt_set_ll_proto_type(pkt,
 						  ntohs(ll_dst_addr->sll_protocol));

-			net_if_queue_tx(net_pkt_iface(pkt), pkt);
+			net_if_try_queue_tx(net_pkt_iface(pkt), pkt, timeout);


context_sendto() has actually more places where data is passed to the lower layer (net_send_data() calls above and below).

Thanks, will take a look.

clamattia · 2025-02-21T12:11:45Z

Added timeouts to more send functions in context_sendto.

clamattia · 2025-02-21T12:34:23Z

Fix compliance issues.

clamattia · 2025-02-21T12:55:23Z

Fix silly mistake
Document timeout parameter

clamattia · 2025-02-25T13:23:42Z

Rebased

clamattia · 2025-02-25T13:27:47Z

Reorder declarations in header files, so they are known for static inline functions.

pdgendt

This looks like a good addition to me.

clamattia · 2025-02-26T09:29:51Z

Fix some CI by using correct k_timeout_t type
Remove no longer needed timeout to K_NO_WAIT in ISR context, because arp and icmp set to K_NO_WAIT in calling context. @rlubos do you agree?

rlubos · 2025-02-26T09:46:13Z

Remove no longer needed timeout to K_NO_WAIT in ISR context, because arp and icmp set to K_NO_WAIT in calling context. @rlubos do you agree?

I'd personally keep it just in case. Just realized, IPv6 ND has probably a similar scenario not handled here (NA reply for NS, in ipv6_nbr.c), maybe there are more cases.

clamattia · 2025-02-26T09:51:44Z

Remove no longer needed timeout to K_NO_WAIT in ISR context, because arp and icmp set to K_NO_WAIT in calling context. @rlubos do you agree?

I'd personally keep it just in case. Just realized, IPv6 ND has probably a similar scenario not handled here (NA reply for NS, in ipv6_nbr.c), maybe there are more cases.

Will add it to the variatn without try.
Makes sense. I just implemented for the ones I was familiar with.

clamattia · 2025-02-26T12:39:38Z

Tried to fix more ci-/compliance-problems
Added @rlubos ISR fix back

clamattia · 2025-02-27T08:38:54Z

More compliance/ci fixes

clamattia · 2025-02-27T08:39:49Z

Rebased

clamattia · 2025-02-27T11:48:49Z

Fixed silly mistake.

clamattia · 2025-02-28T07:57:22Z

ci failure likely unrelated. Will try rebasing soon (hopefully fixed in main?).

Allows to send with different timeouts to not block caller in some situations. Stable API is kept and just calls `try`-variant with a timeout of `K_FOREVER`. Signed-off-by: Cla Mattia Galliard <[email protected]>

Use the newly added timeout in various send functions from within net_context_sendto. Signed-off-by: Cla Mattia Galliard <[email protected]>

This ensures system stays operational in arp-flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

This ensures system stays operation in lldp-flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

This ensure system stays operational in icmp flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

clamattia · 2025-02-28T09:32:40Z

Rebased

clamattia · 2025-03-06T12:27:41Z

Is there anything left to do from my side or is this waiting for the feature defrost :) ?

rlubos · 2025-03-06T12:40:33Z

Is there anything left to do from my side or is this waiting for the feature defrost :) ?

AFAICT it's just waiting for the merge window to open.

zephyrbot added the area: Networking label Feb 21, 2025

zephyrbot requested review from jukkar, pdgendt, rlubos, ssharks and tbursztyka February 21, 2025 08:13

zephyrbot assigned rlubos and jukkar Feb 21, 2025

rlubos reviewed Feb 21, 2025

View reviewed changes

pdgendt reviewed Feb 21, 2025

View reviewed changes

subsys/net/ip/net_core.c Outdated Show resolved Hide resolved

clamattia force-pushed the try_submit_to_tc branch from 394ca9b to 1246770 Compare February 21, 2025 10:00

clamattia changed the title ~~net: RFC: Add timeout to various send functions~~ net: Add timeout to various send functions Feb 21, 2025

rlubos reviewed Feb 21, 2025

View reviewed changes

clamattia force-pushed the try_submit_to_tc branch from 1246770 to 6ea9993 Compare February 21, 2025 12:11

clamattia force-pushed the try_submit_to_tc branch from 6ea9993 to 737abd7 Compare February 21, 2025 12:33

clamattia force-pushed the try_submit_to_tc branch from 737abd7 to d7b8255 Compare February 21, 2025 12:54

clamattia force-pushed the try_submit_to_tc branch from d7b8255 to 46437c4 Compare February 25, 2025 13:23

clamattia force-pushed the try_submit_to_tc branch from 46437c4 to 0c874da Compare February 25, 2025 13:27

pdgendt previously approved these changes Feb 26, 2025

View reviewed changes

clamattia dismissed pdgendt’s stale review via d209da8 February 26, 2025 09:28

clamattia force-pushed the try_submit_to_tc branch from 0c874da to d209da8 Compare February 26, 2025 09:28

clamattia force-pushed the try_submit_to_tc branch from d209da8 to fcda5ab Compare February 26, 2025 12:39

clamattia force-pushed the try_submit_to_tc branch from fcda5ab to dc9e004 Compare February 27, 2025 08:38

clamattia force-pushed the try_submit_to_tc branch from dc9e004 to 1df789c Compare February 27, 2025 08:39

clamattia force-pushed the try_submit_to_tc branch from 1df789c to 5309999 Compare February 27, 2025 11:48

clamattia added 5 commits February 28, 2025 10:27

net: add try variant with timeout for various send functions

7861347

Allows to send with different timeouts to not block caller in some situations. Stable API is kept and just calls `try`-variant with a timeout of `K_FOREVER`. Signed-off-by: Cla Mattia Galliard <[email protected]>

net: net_context: Make use of timeout for sending

78dbdc2

Use the newly added timeout in various send functions from within net_context_sendto. Signed-off-by: Cla Mattia Galliard <[email protected]>

net: arp: Send replies with timeout K_NO_WAIT

6a9bfcf

This ensures system stays operational in arp-flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

net: lldp: Send replies with timeout K_NO_WAIT

5610e11

This ensures system stays operation in lldp-flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

net: icmp: Send replies with timeout K_NO_WAIT

65a1ef7

This ensure system stays operational in icmp flood situation. Signed-off-by: Cla Mattia Galliard <[email protected]>

clamattia force-pushed the try_submit_to_tc branch from 5309999 to 65a1ef7 Compare February 28, 2025 09:27

clamattia requested review from rlubos and pdgendt February 28, 2025 12:59

rlubos approved these changes Feb 28, 2025

View reviewed changes

pdgendt approved these changes Feb 28, 2025

View reviewed changes

jukkar approved these changes Feb 28, 2025

View reviewed changes

jukkar added this to the v4.2.0 milestone Feb 28, 2025

clamattia mentioned this pull request Mar 6, 2025

Feature/backports collection endresshauser-lp/zephyr#5

Closed

carlescufi merged commit 7d721ce into zephyrproject-rtos:main Mar 7, 2025
23 checks passed

clamattia mentioned this pull request Mar 10, 2025

Feature/backports collection 4.1 endresshauser-lp/zephyr#7

Merged

clamattia mentioned this pull request Apr 23, 2025

Contributor Nomination: clamattia #88944

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: Add timeout to various send functions #86127

net: Add timeout to various send functions #86127

clamattia commented Feb 21, 2025 •

edited

Loading

rlubos left a comment

clamattia commented Feb 21, 2025

rlubos Feb 21, 2025

clamattia Feb 21, 2025

clamattia Feb 21, 2025

clamattia commented Feb 21, 2025

clamattia commented Feb 21, 2025

clamattia commented Feb 21, 2025

clamattia commented Feb 25, 2025

clamattia commented Feb 25, 2025

pdgendt left a comment

clamattia commented Feb 26, 2025 •

edited

Loading

rlubos commented Feb 26, 2025

clamattia commented Feb 26, 2025

clamattia commented Feb 26, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 28, 2025

clamattia commented Feb 28, 2025

clamattia commented Mar 6, 2025

rlubos commented Mar 6, 2025

net: Add timeout to various send functions #86127

net: Add timeout to various send functions #86127

Conversation

clamattia commented Feb 21, 2025 • edited Loading

rlubos left a comment

Choose a reason for hiding this comment

clamattia commented Feb 21, 2025

rlubos Feb 21, 2025

Choose a reason for hiding this comment

clamattia Feb 21, 2025

Choose a reason for hiding this comment

clamattia Feb 21, 2025

Choose a reason for hiding this comment

clamattia commented Feb 21, 2025

clamattia commented Feb 21, 2025

clamattia commented Feb 21, 2025

clamattia commented Feb 25, 2025

clamattia commented Feb 25, 2025

pdgendt left a comment

Choose a reason for hiding this comment

clamattia commented Feb 26, 2025 • edited Loading

rlubos commented Feb 26, 2025

clamattia commented Feb 26, 2025

clamattia commented Feb 26, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 27, 2025

clamattia commented Feb 28, 2025

clamattia commented Feb 28, 2025

clamattia commented Mar 6, 2025

rlubos commented Mar 6, 2025

clamattia commented Feb 21, 2025 •

edited

Loading

clamattia commented Feb 26, 2025 •

edited

Loading