Add Support for uart_line_ctrl_set() for UART RTS Line in NXP MCUX LPUART Driver #86710
Conversation
zephyrbot
added
area: UART
zephyrbot
requested review from
dbaluta,
dcpleung,
decsny,
dleach02,
manuargue,
mmahadevan108 and
Raymond0225
nirav-agrawal
force-pushed
the
rts_control_support_mcux_lpuart
branch
from
4abd6d8 to
1757607
Compare
drivers/serial/uart_mcux_lpuart.c
Outdated
| #if CONFIG_UART_LINE_CTRL && \ | ||
| defined(FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT) && FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT |
There was a problem hiding this comment.
nit you can make a macro for this expression since it is used in two places
There was a problem hiding this comment.
sure, thank you
drivers/serial/uart_mcux_lpuart.c
Outdated
| case UART_LINE_CTRL_RTS: | ||
| /* Disable Transmitter and Receiver */ | ||
| config->base->CTRL &= ~(LPUART_CTRL_TE_MASK | LPUART_CTRL_RE_MASK); | ||
|
|
||
| if (val >= 1U) { | ||
| /* Reset TXRTS to set RXRTSE bit, this provides high-level on RTS line */ | ||
| config->base->MODIR &= ~(LPUART_MODIR_TXRTSPOL_MASK | | ||
| LPUART_MODIR_TXRTSE_MASK); | ||
| config->base->MODIR |= LPUART_MODIR_RXRTSE_MASK; | ||
| } else { | ||
| /* Set TXRTSE to reset RXRTSE bit,this provide low-level on RTS line*/ | ||
| config->base->MODIR &= ~(LPUART_MODIR_RXRTSE_MASK); | ||
| config->base->MODIR |= (LPUART_MODIR_TXRTSPOL_MASK | | ||
| LPUART_MODIR_TXRTSE_MASK); | ||
| } | ||
| break; |
There was a problem hiding this comment.
nit is to always make helper function if indent gets greater than 2 levels
There was a problem hiding this comment.
sure, I will update this. thank you.
drivers/serial/uart_mcux_lpuart.c
Outdated
| break; | ||
|
|
||
| default: | ||
| ret = -ENODEV; |
There was a problem hiding this comment.
should be -ENOTSUP according to API if some control option is not enabled I think
There was a problem hiding this comment.
Ok, I will update return value.
drivers/serial/uart_mcux_lpuart.c
Outdated
| #if CONFIG_UART_LINE_CTRL && \ | ||
| defined(FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT) && FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT |
There was a problem hiding this comment.
large expression used in multiple places should make macro for this
There was a problem hiding this comment.
Ok, I will take a macro and use that. thank you.
nirav-agrawal
force-pushed
the
rts_control_support_mcux_lpuart
branch
from
1757607 to
969a378
Compare
|
Hi @decsny, I updated this PR as per your given comments. please review. thank you. |
nirav-agrawal
force-pushed
the
rts_control_support_mcux_lpuart
branch
from
969a378 to
dfd9018
Compare
drivers/serial/uart_mcux_lpuart.c
Outdated
| #if defined(CONFIG_UART_LINE_CTRL) && \ | ||
| defined(FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT) && \ | ||
| (FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT) | ||
| #define CONFIG_UART_LINE_CTRL_ENABLE |
There was a problem hiding this comment.
I think the compliance check will fail because CONFIG_ is reserved for kconfigs
There was a problem hiding this comment.
Hi @decsny, yes it gets failed. I updated that macro and updated this PR. thank you.
- For MCUX LPUART driver, added support to control RTS line High/Low from other driver/app code. - This control is required to wakeup other device which is in sleep and configured its wakeup-source as UART-CTS line. Signed-off-by: Nirav Agrawal <[email protected]>
nirav-agrawal
force-pushed
the
rts_control_support_mcux_lpuart
branch
from
dfd9018 to
86dfa00
Compare
fabiobaltieri
added
the
Trivial
fabiobaltieri
removed
the
Trivial
@dleach02, @DerekSnell, please review this PR. Thank you.
Regards,
Nirav