net: ip: Do not use IPPROTO_RAW for AF_PACKET sockets #86885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AF_PACKET socket protocol field needs to be according to ETH_P_* values (defined in include/net/ethernet.h) and not for IPPROTO_RAW which is only for AF_INET or AF_INET6 family. Fixes zephyrproject-rtos#86827 Signed-off-by: Jukka Rissanen <[email protected]>
|
This PR needs still tweaking. We need first to figure out the correct behavior in different combinations of protocol and address family. See the table in #86827 (comment) for details. |
|
Replaced by #88044 |
Actually, we still need to drop AF_PACKET/IPPROTO_RAW support, my PR only introduces AF_INET/SOCK_RAW. So we'd either need to update this PR, or create a follow up PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AF_PACKET socket protocol field needs to be according to ETH_P_* values (defined in include/net/ethernet.h) and not for IPPROTO_RAW which is only for AF_INET or AF_INET6 family.
Fixes #86827