west: runners: Do not ignore --no-reset in command line or arguments #87138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
carlescufi
reviewed
Mar 14, 2025
scripts/west_commands/run_common.py
Outdated
| @@ -416,7 +416,7 @@ def do_run_common_image(command, user_args, user_runner_args, used_cmds, | |||
| # reset or not. If this is not specified in the board/soc file, leave it up to | |||
| # the runner's default configuration to decide if a reset should occur. | |||
| if runner_cls.capabilities().reset: | |||
| if board_image_count is not None: | |||
| if board_image_count is not None and not '--no-reset' in runner_args: | |||
There was a problem hiding this comment.
Suggested change
| if board_image_count is not None and not '--no-reset' in runner_args: | |
| if board_image_count is not None and '--no-reset' not in runner_args: |
There was a problem hiding this comment.
Considered adding these kind of stuffs in the check compliance scripts? I keep hitting random check fails like that on git ci despite running the recommended pre-PR checks.
VynDragon
force-pushed
the
fix_runners_noreset
branch
from
a14e8f7 to
64107ec
Compare
|
DNM, it is incomplete and doesnt handle when it's set from out of command line |
Prevents this code section from enforcing reset even if --no-reset was passed at some point Signed-off-by: Camille BAUD <[email protected]>
VynDragon
force-pushed
the
fix_runners_noreset
branch
from
64107ec to
f5368e5
Compare
|
Ok it should be good now. |
nordicjm
approved these changes
Mar 18, 2025
pdgendt
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents this code section from enforcing reset even if --no-reset was passed at some point
fixes #87261