mgmt: mcumgr: grp: img_mgmt: Skip erased sectors when erasing #87555
+122
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
mcumgrimgmgmtslimerase
branch
2 times, most recently
from
2e02052 to
127ed09
Compare
Skips erasing sectors that are already erased in a slot erase or image upload command Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
mcumgrimgmgmtslimerase
branch
from
127ed09 to
514cbbf
Compare
de-nordic
reviewed
Apr 23, 2025
| if (action.erase) { | ||
| #if defined(CONFIG_MCUMGR_GRP_IMG_IMAGE_SKIP_ERASED_SECTORS) | ||
| rc = img_mgmt_erase_pending_upload_slot(); |
There was a problem hiding this comment.
I am not sure this is correct. The erase here happens because img_mgmt_flash_check_empty(action->area_id); figured out that there is something in the slot, the problem is that this function will return true even for devices that do not require erase, but erase here is not to remove data (as image erase command does) but to prepare for write, in case of no-erase devices here we have actual opposite action - slowdown due to write operation that "erases" previous image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips erasing sectors that are already erased in a slot erase or image upload command