Skip to content

driver: sleeptimer: siwx917: Add siwx91x Sleeptimer driver #87603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

driver: sleeptimer: siwx917: Add siwx91x Sleeptimer driver #87603

merged 2 commits into from
Apr 3, 2025

Conversation

fimohame
Copy link
Contributor

This commit enables the Sleeptimer driver support for the siwx917 device.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 25, 2025 •
edited by github-actions bot
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@9d32354 zephyrproject-rtos/hal_silabs@40a0237 (main) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Mar 25, 2025
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from 349e9e6 to 4a67912 Compare March 25, 2025 06:20
@fimohame fimohame marked this pull request as ready for review March 25, 2025 08:01
@jhedberg
Copy link
Member

@fimohame how is this different from #87550? Why did you close that one?

@fimohame
Copy link
Contributor Author

I was not able to checkout to that branch... ran into some issues. Wasn't able to access it. Thus created an another branch resolving the compliance issue

@jhedberg
Copy link
Member

I was not able to checkout to that branch... ran into some issues. Wasn't able to access it. Thus created an another branch resolving the compliance issue

You shouldn't need to create a new branch or PR to fix such issues, rather you should be able to just git push --force to the original branch.

@fimohame
Copy link
Contributor Author

Noted.

jerome-pouiller
jerome-pouiller reviewed Mar 25, 2025
View reviewed changes
soc/silabs/silabs_siwx91x/Kconfig.defconfig
@@ -3,6 +3,15 @@

if SOC_FAMILY_SILABS_SIWX91X

configdefault SILABS_SLEEPTIMER_TIMER
default y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLEEPTIMER has some drawbacks. Maybe default y if PM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt PM is still under developement, its noted and would be addressed in that PR.

@fimohame fimohame force-pushed the siwx91x-sleeptimer branch 2 times, most recently from 0116259 to 1e31504 Compare March 26, 2025 11:15
jerome-pouiller
jerome-pouiller reviewed Mar 27, 2025
View reviewed changes
@jerome-pouiller
Copy link
Collaborator

@fimohame don't forget to look at the issue reported by twister (it seems it dislike the way you declare the code relocation)

@rettichschnidi rettichschnidi removed their request for review March 31, 2025 13:36
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from 1e31504 to 8300d76 Compare March 31, 2025 16:01
@fimohame fimohame closed this Apr 1, 2025
@fimohame fimohame reopened this Apr 1, 2025
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch 5 times, most recently from 1a4f172 to 99ba0eb Compare April 2, 2025 06:31
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Apr 2, 2025
@fimohame fimohame closed this Apr 2, 2025
@fimohame fimohame reopened this Apr 2, 2025
jerome-pouiller
jerome-pouiller reviewed Apr 2, 2025
View reviewed changes
soc/silabs/silabs_siwx91x/Kconfig Outdated
config SOC_SILABS_SLEEPTIMER
bool
help
The Sleeptimer HAL module is used for SIWX91X.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a indentation error

jerome-pouiller
jerome-pouiller reviewed Apr 2, 2025
View reviewed changes
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from 99ba0eb to da4204c Compare April 2, 2025 11:57
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from da4204c to 35aea4f Compare April 2, 2025 14:26
@fimohame fimohame requested a review from jerome-pouiller April 2, 2025 14:37
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from fbd0787 to 47d31ee Compare April 2, 2025 14:59
fimohame added 2 commits April 2, 2025 20:40
@fimohame
driver: sleeptimer: siwx917: Add siwx91x Sleeptimer driver
cd57546 
This commit enables the Sleeptimer driver support for the siwx917 device.

Signed-off-by: S Mohamed Fiaz <[email protected]>
@fimohame
west.yml: Update hal_silabs revision
b7ce3ee 
This commit updates the hal_silabs revision

Signed-off-by: S Mohamed Fiaz <[email protected]>
@fimohame fimohame force-pushed the siwx91x-sleeptimer branch from 47d31ee to b7ce3ee Compare April 2, 2025 15:11
@kartben kartben merged commit 2eb0fb2 into zephyrproject-rtos:main Apr 3, 2025
27 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

Hi @fimohame!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@jerome-pouiller jerome-pouiller jerome-pouiller approved these changes

@asmellby asmellby asmellby approved these changes

@Martinhoff-maker Martinhoff-maker Martinhoff-maker approved these changes

@andyross andyross Awaiting requested review from andyross

@mnkp mnkp Awaiting requested review from mnkp

@teburd teburd Awaiting requested review from teburd

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@jhedberg jhedberg

@asmellby asmellby

Labels
area: Timer Timer manifest manifest-hal_silabs platform: Silabs Silicon Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fimohame @zephyrbot @jhedberg @jerome-pouiller @asmellby @Martinhoff-maker @kartben