-
Notifications
You must be signed in to change notification settings - Fork 7.3k
samples: blinky: add support for non-standard led displays #87613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
samples: blinky: add support for non-standard led displays #87613
Conversation
Hello @AndOrangutan, and thank you very much for your first pull request to the Zephyr project! |
17b51a0
to
52783de
Compare
Extend device tree to work with blinky sample. Signed-off-by: Von Mueller <[email protected]>
Some boards, such as the MicroBit v2, have no controllable simple leds. This allows matrix displays to blink a single led. Signed-off-by: Von Mueller <[email protected]>
52783de
to
b6dc7b9
Compare
Hello @AndOrangutan, thanks for extending the blinky sample code so that it works on boards without a simple LED connection. Could you updated the README.rst to include the additional LED and how the two LED pins work together to toggle a single matrix LED. And that the additional LED is optional for non-matrix LED displays, but if it's implemented, blinky will simply toggle both LEDs. |
This is complexifying blinky quite a bit for a sample that's meant to be pretty much the next step after "hello world" for most users. I might be missing somethign but it looks like what's needed is rather a new binding/driver that would allow to configure a given LED from an LED matrix as an LED device? |
True, @kartben, technically the root problem I wanted to solve was there being no working blinky example for the MicroBit v2 board. I'm not really sure how many other boards even have matrix displays, but I see a couple ways of remedying it:
With this board being a learner board, it would be useful to have some sort of working blinky. I'm not trying to add unneeded complexity, do you have a preferred solution? |
Hello @kartben, could you comment on @AndOrangutan reply? |
Ya I think solution 1 is probably better (although note that there is already a sample for the LED matrix). |
This is a change to enable the blinky sample to work on matrix displays such as the common learner board MicroBit v2.