Skip to content

lvgl: Add config to disable monochrome pixel software inversion #87928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vulporuza
Copy link
Contributor

In some cases, pixel inversion is managed by the display hardware (e.g. SSD1306) and software inversion is not required (as it disables the hardware inversion). This PR adds a configuration to disable this inversion.

@github-actions github-actions bot added area: LVGL Light and Versatile Graphics Library Support area: Shields Shields (add-on boards) labels Mar 31, 2025
@vulporuza vulporuza force-pushed the hardware-color-inversion branch 2 times, most recently from 572780e to 9a42fb7 Compare March 31, 2025 20:55
@uLipe
Copy link
Member

uLipe commented Mar 31, 2025

The code looks good, please just check the failing tests.

@pdgendt
Copy link
Collaborator

pdgendt commented Apr 1, 2025

The code looks good, please just check the failing tests.

Not sure if the CI failure is related? 🤔 Restarted the job to make sure.

faxe1008
faxe1008 previously approved these changes Apr 1, 2025
uLipe
uLipe previously approved these changes Apr 1, 2025
kartben
kartben previously requested changes Apr 2, 2025
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the new Kconfig option in the release notes

@vulporuza vulporuza dismissed stale reviews from uLipe and faxe1008 via 30d19d4 April 6, 2025 18:53
@vulporuza vulporuza force-pushed the hardware-color-inversion branch from 9a42fb7 to 30d19d4 Compare April 6, 2025 18:53
@github-actions github-actions bot added the Release Notes To be mentioned in the release notes label Apr 6, 2025
@github-actions github-actions bot requested a review from fabiobaltieri April 6, 2025 18:54
@vulporuza vulporuza requested review from kartben, faxe1008 and uLipe April 6, 2025 19:50
faxe1008
faxe1008 previously approved these changes Apr 9, 2025
fabiobaltieri
fabiobaltieri previously approved these changes Apr 10, 2025
uLipe
uLipe previously approved these changes Apr 10, 2025
@kartben kartben dismissed their stale review April 14, 2025 09:43

addressed

@vulporuza vulporuza dismissed stale reviews from uLipe, fabiobaltieri, and faxe1008 via d25cc8b April 17, 2025 06:14
@vulporuza vulporuza force-pushed the hardware-color-inversion branch from d25cc8b to 60840ea Compare April 17, 2025 06:28
uLipe
uLipe previously approved these changes Apr 24, 2025
faxe1008
faxe1008 previously approved these changes Apr 25, 2025
In some cases, pixel inversion is managed by the display hardware
and software inversion is not required.

Signed-off-by: Robin-Charles Guihéneuf <[email protected]>
On this screen the inversion is managed by hardware.

Signed-off-by: Robin-Charles Guihéneuf <[email protected]>
@vulporuza vulporuza dismissed stale reviews from faxe1008 and uLipe via 5876ba0 April 28, 2025 07:24
@vulporuza vulporuza force-pushed the hardware-color-inversion branch from 60840ea to 5876ba0 Compare April 28, 2025 07:24
@MaureenHelm MaureenHelm merged commit e1c5e3a into zephyrproject-rtos:main Apr 28, 2025
24 checks passed
@vulporuza vulporuza deleted the hardware-color-inversion branch April 28, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LVGL Light and Versatile Graphics Library Support area: Shields Shields (add-on boards) Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants