-
Notifications
You must be signed in to change notification settings - Fork 7.3k
lvgl: Add config to disable monochrome pixel software inversion #87928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaureenHelm
merged 2 commits into
zephyrproject-rtos:main
from
vulporuza:hardware-color-inversion
Apr 28, 2025
Merged
lvgl: Add config to disable monochrome pixel software inversion #87928
MaureenHelm
merged 2 commits into
zephyrproject-rtos:main
from
vulporuza:hardware-color-inversion
Apr 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
572780e
to
9a42fb7
Compare
The code looks good, please just check the failing tests. |
Not sure if the CI failure is related? 🤔 Restarted the job to make sure. |
faxe1008
previously approved these changes
Apr 1, 2025
uLipe
previously approved these changes
Apr 1, 2025
kartben
previously requested changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention the new Kconfig option in the release notes
9a42fb7
to
30d19d4
Compare
faxe1008
previously approved these changes
Apr 9, 2025
fabiobaltieri
previously approved these changes
Apr 10, 2025
uLipe
previously approved these changes
Apr 10, 2025
kartben
previously requested changes
Apr 14, 2025
d25cc8b
d25cc8b
to
60840ea
Compare
uLipe
previously approved these changes
Apr 24, 2025
faxe1008
previously approved these changes
Apr 25, 2025
In some cases, pixel inversion is managed by the display hardware and software inversion is not required. Signed-off-by: Robin-Charles Guihéneuf <[email protected]>
On this screen the inversion is managed by hardware. Signed-off-by: Robin-Charles Guihéneuf <[email protected]>
60840ea
to
5876ba0
Compare
kartben
approved these changes
Apr 28, 2025
fabiobaltieri
approved these changes
Apr 28, 2025
faxe1008
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: LVGL
Light and Versatile Graphics Library Support
area: Shields
Shields (add-on boards)
Release Notes
To be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, pixel inversion is managed by the display hardware (e.g. SSD1306) and software inversion is not required (as it disables the hardware inversion). This PR adds a configuration to disable this inversion.