pm: Use fixed cpu id in single core case #88144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
ceolin,
JordanYates,
nashif,
teburd and
tmleman
JordanYates
reviewed
Apr 4, 2025
nordic-krch
force-pushed
the
pm_single_core
branch
from
5220f6c to
518fa5d
Compare
JordanYates
previously approved these changes
Apr 4, 2025
|
Could ROM savings be obtained across other users in the codebase? |
nordic-krch
force-pushed
the
pm_single_core
branch
from
518fa5d to
0ce6110
Compare
github-actions
bot
requested review from
cfriedt,
dcpleung,
npitre,
peter-mitsis and
TaiJuWu
nordic-krch
force-pushed
the
pm_single_core
branch
from
0ce6110 to
411d291
Compare
|
Added |
nordic-krch
force-pushed
the
pm_single_core
branch
from
411d291 to
b4b2b9e
Compare
JordanYates
reviewed
Apr 4, 2025
In case of a single core it resolves to 0. In many cases it reduces code size and execution time compared to reading id in runtime. Signed-off-by: Krzysztof Chruściński <[email protected]>
When there are no multiple cores than fixing id to 0 saves few cycles. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
pm_single_core
branch
from
b4b2b9e to
d32d51b
Compare
github-actions
bot
requested review from
LucasTambor,
marekmatej and
sylvioalves
JordanYates
approved these changes
Apr 7, 2025
Driver is using local macro to get current CPU ID and it is now in conflict with generic CPU_ID. Added prefix to avoid conflict. Signed-off-by: Krzysztof Chruściński <[email protected]>
marekmatej
approved these changes
Apr 7, 2025
sylvioalves
approved these changes
Apr 7, 2025
peter-mitsis
approved these changes
Apr 7, 2025
tmleman
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no multiple cores than fixing id to 0 saves few cycles.
Do not call ticks_expiring_sooner if not needed.
This small improvement saves few cycles but surprisingly significantly reduces
pm.ccode size 416 to 316 bytes in the sample that I've checked.