Bluetooth: ISO Broadcast shell updates #88151
Open
+101
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth
area: Bluetooth ISO
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- doc/connectivity/bluetooth/shell/host/iso.rst: Language not supported
Comments suppressed due to low confidence (2)
subsys/bluetooth/host/shell/iso.c:799
- Changing the argument index to argv[2] appears to be a fix for correctly parsing the broadcast code. Please verify that the expected argument count and command usage align with this update.
size_t bcode_len = hex2bin(argv[2], strlen(argv[2]), param.bcode, sizeof(param.bcode));
subsys/bluetooth/host/shell/iso.c:802
- [nitpick] While including the broadcast code length in the error message adds useful context, ensure that exposing this detail does not have unintended side effects in production environments.
shell_error(sh, "Invalid Broadcast Code Length %zu", bcode_len);
Thalley
force-pushed
the
iso_broadcast_enc_fix
branch
from
1d88d31 to
9576c4c
Compare
The broadcast code was attempting to read from argv[1] instead of argv[2] that actually contains the broadcast code. Signed-off-by: Emil Gydesen <[email protected]>
Add examples of how to use the ISO shell with broadcast. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
iso_broadcast_enc_fix
branch
from
9576c4c to
daeb7d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with broadcast code as the broadcaster and updates the shell documentation.