Bluetooth: BAP: Sink: Move mod_src_param to RAM #88251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mod_src_param was several places stored on the stack. However this is a complex paramater struct that has 2 Kconfig options that can significantly increase the size, and the maximum size of the parameter is nearly 8 KiB, and was always place the in the BT RX thread's stack. For this reason, the param is now stored in a single static variable in RAM instead, so that the BT RX thread's stack does not need to be increased based on the Kconfig options, as that is quite difficult for users to be aware of. The add_src_param has been left as is, as that stored in the calling thread, and it is easier for an application to determine if the calling thread needs additional stack space. Signed-off-by: Emil Gydesen <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
subsys/bluetooth/audio/bap_broadcast_sink.c:66
- [nitpick] Consider rephrasing the comment for clarity, e.g., 'The mod_src_param is intended to be used solely by the BT RX thread and is statically allocated due to its configurable size.'
/* The mod_src_param is and shall only be used by the BT RX thread. It is statically defined due to
subsys/bluetooth/audio/bap_broadcast_sink.c:514
- Since the function no longer accepts a mod_src_param parameter and instead uses the global instance, update its documentation and/or naming to clearly reflect this change.
static int update_recv_state_base_copy_meta(const struct bt_bap_base *base)
github-actions
bot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
larsgk
approved these changes
Apr 19, 2025
babrsn
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mod_src_param was several places stored on the stack. However this is a complex paramater struct that has 2 Kconfig options that can significantly increase the size, and the maximum size of the parameter is nearly 8 KiB, and was always place the in the BT RX thread's stack.
For this reason, the param is now stored in a single static variable in RAM instead, so that the BT RX thread's stack does not need to be increased based on the Kconfig options, as that is quite difficult for users to be aware of.
The add_src_param has been left as is, as that stored in the calling thread, and it is easier for an application to determine if the calling thread needs additional stack space.