Fix xtensa project build issue #88305
Conversation
ZhaoxiangJin
changed the title
github-actions
bot
requested review from
bperseghetti,
decsny,
dleach02,
manuargue,
mmahadevan108 and
PetervdPerk-NXP
|
Hi @hakehuang , please help to test build RT700 HIFI1 and HIFI4 with this PR, thanks. |
build is PASS for both platforms. @ZhaoxiangJin , @zejiang0jason |
| @@ -39,7 +39,11 @@ endif() | |||
| set(CONFIG_MCUX_COMPONENT_device.system ON) | |||
| set(CONFIG_MCUX_COMPONENT_device.CMSIS ON) | |||
| set(CONFIG_MCUX_COMPONENT_driver.clock ON) | |||
| set(CONFIG_MCUX_COMPONENT_driver.power ON) | |||
|
|
|||
| if((NOT CONFIG_SOC_MIMXRT798S_HIFI1) AND (NOT CONFIG_SOC_MIMXRT798S_HIFI4)) | |||
There was a problem hiding this comment.
Is this only an issue on RT700 HIFI core?
Do we need to use the below instead?
if(CONFIG_ARCH STREQUAL "xtensa")
There was a problem hiding this comment.
Hello @mmahadevan108, for other xtensa platform:
- The problem with RT700 is that the kconfig option HAS_MCUX is selected by SOC_MIMXRT798S_HIFI4/SOC_MIMXRT798S_HIFI1. At this time, the fsl_power.c/.h file will be loaded, which uses some ARM architecture-related registers and instructions. Then the build process will be broken.
- RT500 Fusion has no such problem, because SOC_MIMXRT595S_F1 does not select the kconfig option HAS_MCUX, so fsl_power.c/.h will not load.
- imx8xx dsp project has no fsl_power.c/.h
Therefore, the current conditions are sufficient.
There was a problem hiding this comment.
@ZhaoxiangJin thank you for your response.
@iuliana-prodan, do we need HAS_MCUX selected? This is not selected for RT595, hence checking.
- The fsl_common_dsp driver needs to be loaded
when building xtensa projects and the fsl_common_arm
driver needs to be loaded when building arm projects.
- Add a condition to load power driver, because the power
driver is needed to build RT700 arm core project, but it
is not needed to build hifi core project.
Signed-off-by: Zhaoxiang Jin <[email protected]>
ZhaoxiangJin
force-pushed
the
fix_xtensa-project-build-issue
branch
from
86eca14 to
5e24446
Compare
|
fixed merge conflict. |
|
Hello @mmahadevan108, seems some other PRs are blocked by this PR, can we approve this PR first? |
This PR fix #82635 CI build issue.