samples: spi_flash: add support for blackpill_f411ce #88309
Conversation
javad123javad
force-pushed
the
project/weact_blackpillf411ce_add_flash
branch
from
41874d7 to
004c167
Compare
| */ | ||
|
|
||
| &spi1 { | ||
| pinctrl-0 = <&spi1_sck_pa5 &spi1_miso_pa6 &spi1_mosi_pa7>; |
There was a problem hiding this comment.
are you sure this is correct? The board revision currently supported in Zephyr is v2.0.
There was a problem hiding this comment.
On the board that I have on my side, this configuration is working. But when I change the miso to pb4, it doesn't work.
There was a problem hiding this comment.
yes but my point is "your" board is probably not a v2.0... maybe a v2.1?
https://github.com/WeActStudio/WeActStudio.MiniSTM32F4x1/blob/master/HDK/README.md
There was a problem hiding this comment.
Ah, just got it. I think so. Even though the rev number is not on my board.
I can modify it to use pb4 ?
There was a problem hiding this comment.
Maybe revision is visible in this spot? https://github.com/WeActStudio/WeActStudio.MiniSTM32F4x1/blob/master/images%2FSTM32F4x1C_Logo%26Version.png
There was a problem hiding this comment.
@kartben can you please review this PR? Should I change it based on rev 2.1 board?
There was a problem hiding this comment.
The board supported in Zephyr is rev 2.0 so either the overlay should be set to work with 2.0. I guess if you want to support 3.x this is instead blackpill_f401ce you are looking at? https://docs.zephyrproject.org/latest/boards/weact/blackpill_f401ce/doc/index.html
There was a problem hiding this comment.
Yes, it looks like this board, but the micro is F411. I will update the PR to be compatible with V2.0
There was a problem hiding this comment.
thanks! one last question/comment: the flash chip is actually not populated out-of-the-box, right? if that's the case, maybe worth adding a comment in the overlay file indicating that it might need tweaks depending on which actual chip (size, etc.) people end up soldering
There was a problem hiding this comment.
On my board, it was already soldered. But I agree with you about adding comments in the overlay to modify the chip size or even pin assignments based on their actual boards.
javad123javad
force-pushed
the
project/weact_blackpillf411ce_add_flash
branch
3 times, most recently
from
2da3d67 to
f2a7766
Compare
This commit add spi nor flash support for blackpill_f411ce board Signed-off-by: Javad Rahimipetroudi <[email protected]>
javad123javad
force-pushed
the
project/weact_blackpillf411ce_add_flash
branch
from
f2a7766 to
a65057c
Compare
This commit adds flash support for blackpill_f411ce boards.