Simics environment variable usage #88312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A message about not finding simics at SIMICS_PROJECT env var was not showing the current value of said variable. Signed-off-by: Ederson de Souza <[email protected]>
github-actions
bot
requested review from
57300,
gchwier,
golowanow,
hakehuang,
jeremybettis,
KamilxPaszkiet,
LukaszMrugala,
nashif,
nordicjm,
PerMac and
tejlmand
edersondisouza
force-pushed
the
simics-env-var
branch
from
8a8056b to
d7ea6d2
Compare
hakehuang
reviewed
Apr 9, 2025
tejlmand
previously approved these changes
Apr 10, 2025
golowanow
reviewed
Apr 10, 2025
While cmake/emu/simics.cmake uses SIMICS_PROJECT env var, twister checks if a build is "runnable" by checking if `simics` is executable, but it doesn't look at SIMICS_PROJECT env var. Signed-off-by: Ederson de Souza <[email protected]>
edersondisouza
force-pushed
the
simics-env-var
branch
from
d7ea6d2 to
bb685d2
Compare
|
v2:
|
golowanow
approved these changes
Apr 11, 2025
hakehuang
approved these changes
Apr 11, 2025
tejlmand
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMICS_PROJECTenvironment variable to being consistently used: