tests: Bluetooth: tester: BAP: Fix wrong wrong bcast rsp sizes #88364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several responses had incorrect sizes, which this commit fixes. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
added
bug
github-actions
bot
added
area: Bluetooth
area: Bluetooth Qualification
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/bluetooth/tester/src/audio/btp_bap_broadcast.c:477
- Removing '+1' aligns the response size with the actual structure size, but please double-check that this change matches the expected behavior in all cases of broadcast responses.
*rsp_len = sizeof(*rp);
tests/bluetooth/tester/src/audio/btp_bap_broadcast.c:592
- Ensure that the updated response size calculation uniformly fixes the incorrect sizes for both functions without introducing discrepancies in the expected byte layout.
*rsp_len = sizeof(*rp);
sjanc
approved these changes
Apr 9, 2025
alexsven
approved these changes
Apr 9, 2025
larsgk
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several responses had incorrect sizes, which this commit fixes.