drivers/pwm/it51xxx: implement pwm driver #88471
Open
+487
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: PWM
github-actions
bot
requested review from
anangl,
brockus-zephyr,
carlocaione,
Dino-Li,
edersondisouza,
fkokosinski,
GTLin08,
henrikbrixandersen,
jackrosenthal,
katsuster,
keith-zephyr,
kgugala,
mgielda,
sjg20 and
tgorochowik
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
from
64f8e38 to
16b8f8f
Compare
|
rebase to resolve conflicts |
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
from
16b8f8f to
c46a508
Compare
|
rebase to resolve conflicts |
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
2 times, most recently
from
e25f117 to
ee9bea9
Compare
|
rebase to resolve conflicts |
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
from
ee9bea9 to
26a8d3d
Compare
|
rebase to resolve conflicts |
Dino-Li
reviewed
Apr 30, 2025
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
from
26a8d3d to
ed1d7f5
Compare
|
Hi @anangl, any comments will be appreciated. |
Dino-Li
previously approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new PWM driver for the ITE it51xxx series chip.
- Introduces a header file with device binding macros and definitions.
- Adds a DTS binding YAML file defining device properties and PWM cells.
- Implements the PWM driver in a new source file with configuration, initialization, and cycle setting logic.
Reviewed Changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/zephyr/dt-bindings/pwm/it51xxx_pwm.h | Added binding definitions and macro constants for PWM configuration. |
| dts/bindings/pwm/ite,it51xxx-pwm.yaml | Defined device properties and bindings for the PWM controller. |
| drivers/pwm/pwm_ite_it51xxx.c | Implemented the PWM driver including initialization and cycle logic. |
Files not reviewed (5)
- boards/ite/it515xx_evb/it515xx_evb.dts: Language not supported
- drivers/pwm/CMakeLists.txt: Language not supported
- drivers/pwm/Kconfig: Language not supported
- drivers/pwm/Kconfig.it51xxx: Language not supported
- dts/riscv/ite/it51xxx.dtsi: Language not supported
| * Provides a type to hold PWM configuration flags. | ||
| * | ||
| * The upper 8 bits are reserved for SoC specific flags. | ||
| * Output onpe-drain flag [ 8 ] |
There was a problem hiding this comment.
Typo in the comment: 'onpe-drain' should be corrected to 'open-drain'.
Suggested change
| * Output onpe-drain flag [ 8 ] | |
| * Output open-drain flag [ 8 ] |
Copilot uses AI. Check for mistakes.
RuibinChang
force-pushed
the
it51xxx_evb_pwm
branch
from
ed1d7f5 to
81df179
Compare
Implement pwm driver for ITE it51xxx series chip. Signed-off-by: Ruibin Chang <[email protected]>
Dino-Li
approved these changes
May 2, 2025
fabiobaltieri
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement pwm driver for ITE it51xxx series chip.