soc/intel_adsp/ace: custom arch_spin_relax and some syscalls related changes. #88525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...earlier. Similar to xtensa_do_syscall, we want to group some functions together. Signed-off-by: Daniel Leung <[email protected]>
For some weird unknown reasons, the simulator really do not like the cpuhold_* variables to be tightly packed together. This results in cpuhold_spawned not being updated, and we will be stuck in the while loop for it to be set. Workaround this by explicitly aligning these variables on 16 byte boundary. This seems to work for now. Signed-off-by: Daniel Leung <[email protected]>
Intel Audio DSP ACE needs to use arch_spin_relax() to give the bus more time to propagate the RCW transactions among CPUs, and to avoid sending too many requests to the bus after failing to lock spinlocks. However, the number of NOPs results in a very big arch_spin_relax() that spans multiple instruction cache lines, and requires evicting them just for NOPs. With 5 CPUs, it can span 6 cache lines (if using nop.n instead of nop). That's a waste of space and cache. So instead, we do a tight loop instead. Since the SoC supports zero-overhead loops, this should have minimal performance impact. Signed-off-by: Daniel Leung <[email protected]>
dcpleung
force-pushed
the
soc/intel_adsp/misc_syscall_test_fixes
branch
from
cf577a6 to
2ccc90b
Compare
github-actions
bot
requested review from
andyross,
ceolin,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
nashif,
softwarecki and
tmleman
tmleman
approved these changes
Apr 16, 2025
ceolin
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See individual commits for more details.)