bluetooth: rename _bt_gatt_ccc and clarify usage #88652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth Host
github-actions
bot
requested review from
akredalen,
alwa-nordic,
Andrewpini,
cvinayak,
HaavardRei,
hermabe,
jhedberg,
KyraLengfeld,
LingaoM,
omkar3141,
PavelVPV,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
alxelax
force-pushed
the
clarify_use_gatt_ccc
branch
from
63a5f96 to
21ad633
Compare
jhedberg
reviewed
Apr 15, 2025
alxelax
force-pushed
the
clarify_use_gatt_ccc
branch
from
21ad633 to
0575c2c
Compare
|
Do I need to add it into #86000 ? |
alwa-nordic
previously approved these changes
Apr 15, 2025
Yes |
jhedberg
previously approved these changes
Apr 16, 2025
Bluetooth had two public types with similar name _bt_gatt_ccc and bt_gatt_ccc, but for absolutely different purposes. That caused misunderstanding of relationship of them and cases where to use which one. Commit changes name of _bt_gatt_ccc to more suitable by usage and improves documentation of it. Additionally, it changes name of BT_GATT_CCC_INITIALIZER to correspond the type name. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
clarify_use_gatt_ccc
branch
from
0575c2c to
fa67619
Compare
KyraLengfeld
approved these changes
Apr 16, 2025
jhedberg
approved these changes
Apr 16, 2025
alwa-nordic
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluetooth had two public types with similar name _bt_gatt_ccc and bt_gatt_ccc, but for absolutely different purposes. That caused misunderstanding of relationship of them and cases where to use which one.
Commit changes name of _bt_gatt_ccc to more suitable by usage and improves documentation of it.
Additionally, it changes name of BT_GATT_CCC_INITIALIZER to correspond the type name.