drivers: stepper: refactor stepper move_to and move_by calls #88676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
fabiobaltieri,
faxe1008,
galak,
jbehrensnx,
jilaypandya,
MaureenHelm,
microbuilder,
ozersa,
ttmut and
yasinustunerg
dipakgmx
force-pushed
the
feat/stepper-refactor-clones
branch
from
03c76c2 to
ebf6203
Compare
dipakgmx
changed the title
dipakgmx
force-pushed
the
feat/stepper-refactor-clones
branch
from
ebf6203 to
1b7ff30
Compare
jilaypandya
reviewed
Apr 15, 2025
| } | ||
| int32_t target_position = position + micro_steps; | ||
|
|
||
| LOG_DBG("Stepper motor controller %s moved to %d by steps: %d", dev->name, target_position, |
There was a problem hiding this comment.
LOG_DBG("%s moved to %d by steps: %d", dev->name, target_position,
dipakgmx
force-pushed
the
feat/stepper-refactor-clones
branch
2 times, most recently
from
399f583 to
aec7aa0
Compare
Refactored stepper move_to calls and move_by calls. Now, relative movement required or absolute target position is calculated and then redirected to move_by or move_to calls respectively. Signed-off-by: Dipak Shetty <[email protected]>
dipakgmx
force-pushed
the
feat/stepper-refactor-clones
branch
from
aec7aa0 to
9675be9
Compare
jilaypandya
approved these changes
Apr 16, 2025
faxe1008
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored stepper move_to calls and move_by calls.
Now, relative movement required, or the absolute target position
is calculated and then redirected to move_by or move_to calls
respectively.