drivers: pinctrl: Add sdif configs to ambiq pinctrl driver #88738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
soc/ambiq/apollo4x/pinctrl_soc.h:42
- [nitpick] Consider clarifying the comment to specify valid values (e.g., 0: not SDIF pin, 1: SDIFCD, 2: SDIFWP) for the sdif_cdwp field.
+ /** SDIF CD WP pad select */
github-actions
bot
requested review from
aaronyegx,
gmarull and
RichardSWheatley
aaronyegx
previously approved these changes
Apr 18, 2025
swift-tk
previously approved these changes
Apr 18, 2025
|
@AlessandroLuo please rebase |
Added sdio cd and wp pin configs to ambiq pinctrl driver Signed-off-by: Hao Luo <[email protected]>
AlessandroLuo
force-pushed
the
ambiq-sdif-pin
branch
from
94cf3d7 to
99f332e
Compare
aaronyegx
approved these changes
Apr 22, 2025
swift-tk
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sdio cd and wp pin configs to ambiq pinctrl driver