Skip to content

dts: common: nordic: nrf52840_partitions: Use equal partitions #88750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

dts: common: nordic: nrf52840_partitions: Use equal partitions #88750

merged 1 commit into from
Apr 23, 2025

Conversation

nordicjm
Copy link
Collaborator

Switches back to equal sized partitions, this fixes an issue whereby the number of overhead sectors for a swap mode was incorrectly listed as 2 when it should have been 1, and also allows using any swap mode. This means that when using swap using mode, 1 sector in the secondary partition will be unusable, and when using swap using offset, 1 sector in the primary partition will be unusable

@nordicjm
dts: common: nordic: nrf52840_partitions: Use equal partitions
9cb2339 
Switches back to equal sized partitions, this fixes an issue
whereby the number of overhead sectors for a swap mode was
incorrectly listed as 2 when it should have been 1, and also
allows using any swap mode. This means that when using swap
using mode, 1 sector in the secondary partition will be unusable,
and when using swap using offset, 1 sector in the primary
partition will be unusable

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm added the Regression Something, which was working, does not anymore label Apr 17, 2025
@nordicjm nordicjm requested review from de-nordic and gchwier April 17, 2025 07:58
@github-actions github-actions bot added the platform: nRF Nordic nRFx label Apr 17, 2025
@gchwier
Copy link
Collaborator

gchwier commented Apr 17, 2025

Fixed tests:

nrf52840dk/nrf52840:tests/boot/test_mcuboot/bootloader.mcuboot
nrf52840dk/nrf52840:tests/boot/with_mcumgr/boot.with_mcumgr.test_upgrade
nrf52840dk/nrf52840:tests/boot/with_mcumgr/boot.with_mcumgr.test_downgrade_prevention

one left:
nrf52840dk/nrf52840:tests/boot/mcuboot_data_sharing/bootloader.mcuboot.data.sharing
with error log:

START - test_max_application_size

    Assertion failed at ../../../../../../../../zephyr/tests/boot/mcuboot_data_sharing/src/main.c:98: mcuboot_shared_data_test_max_application_size: (value not equal to FLASH_MAX_APP_SIZE)
Expected data mismatch
 FAIL - test_max_application_size in 0.019 seconds

@nordicjm
Copy link
Collaborator Author

@anangl @masz-nordic please review

gchwier
gchwier approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@gchwier gchwier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootloader.mcuboot.data.sharing can be fixed in a separate PR

@kartben kartben merged commit a4e41f4 into zephyrproject-rtos:main Apr 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anangl anangl anangl approved these changes

@de-nordic de-nordic de-nordic approved these changes

@gchwier gchwier gchwier approved these changes

@jaz1-nordic jaz1-nordic Awaiting requested review from jaz1-nordic

@kl-cruz kl-cruz Awaiting requested review from kl-cruz

@magp-nordic magp-nordic Awaiting requested review from magp-nordic

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

Assignees

@anangl anangl

@masz-nordic masz-nordic

Labels
platform: nRF Nordic nRFx Regression Something, which was working, does not anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nordicjm @gchwier @anangl @de-nordic @kartben @masz-nordic