drivers: nrf: pinctrl: allow SoC-specific hooks #88753
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to HAL functions in NRF pinctrl. Signed-off-by: Marcin Szymczyk <[email protected]>
* Move per-peripheral configuration to separate functions. * Iterate over a table of functions instead of huge switch-case. * Other minor improvements. Signed-off-by: Marcin Szymczyk <[email protected]>
Instead of cluttering the generic driver, move SoC-specific code to separate files. Signed-off-by: Marcin Szymczyk <[email protected]>
GPD is necessary for nRF54H20 application and radio code. Provide hooks and select Kconfigs to enable them. Signed-off-by: Marcin Szymczyk <[email protected]>
bjarki-andreasen
requested changes
Apr 24, 2025
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include <nrf/gpd.h> |
There was a problem hiding this comment.
something seems wrong with the includes here, this file should include zephyr/drivers/pinctrl/nrf_pinctrl.h (a file which does not exist yet, but it should, the hooks are device driver specific, not soc specific)
| @@ -26,6 +27,18 @@ extern "C" { | |||
| /** Type for nRF pin. */ | |||
| typedef uint32_t pinctrl_soc_pin_t; | |||
|
|
|||
|
|
|||
| struct nrf_pinctrl_pin { | |||
There was a problem hiding this comment.
Please move this struct and the hook declarations to a device driver specific header in include/zephyr/drivers/pinctrl/
these syms are not soc specific, they are device driver specific :) The SoC "merely" implements them :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.