drivers: counter: siwx91x: Enable siwx91x Counter driver #88756
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable sleeptimer counter driver for siwx91x device Signed-off-by: Sai Santhosh Malae <[email protected]>
github-actions
bot
added
area: Counter
platform: Silabs
github-actions
bot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
kartben,
Martinhoff-maker,
nashif and
nordic-krch
asmellby
reviewed
Apr 25, 2025
| select SOC_SILABS_SLEEPTIMER | ||
| help | ||
| Enable the counter driver for Sleep Timer module for Silicon Labs | ||
| Gecko chips. | ||
|
|
||
| if SOC_FAMILY_SILABS_SIWX91X |
There was a problem hiding this comment.
I don't see why a new Kconfig option needs to be added, the existing one should be sufficient and work for both Series 2 and SiWx91x.
| @@ -281,7 +276,9 @@ BUILD_ASSERT((DT_INST_PROP(0, prescaler) > 0U) && (DT_INST_PROP(0, prescaler) <= | |||
|
|
|||
| static void counter_gecko_0_irq_config(void) | |||
| { | |||
| IRQ_DIRECT_CONNECT(DT_INST_IRQN(0), DT_INST_IRQ(0, priority), STIMER_IRQ_HANDLER, 0); | |||
| IRQ_DIRECT_CONNECT(DT_IRQ(DT_RTC, irq), DT_IRQ(DT_RTC, priority), | |||
There was a problem hiding this comment.
The responsibility of interrupt configuration between the Timer and Counter drivers needs to be decided, they shouldn't both configure it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sleeptimer counter driver for siwx91x device